# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1422371663 18000
# Node ID 1f3b94e8dc4012051482f54b51a07ff66e15dee2
# Parent  bc851e2851b1b1a203744b548f453d0e030b09cc
osutil: fix leak of stat in makestat when Py_BuildValue fails

Spotted with cpychecker.

diff --git a/mercurial/osutil.c b/mercurial/osutil.c
--- a/mercurial/osutil.c
+++ b/mercurial/osutil.c
@@ -288,7 +288,7 @@
 
 static PyObject *_listdir(char *path, int pathlen, int keepstat, char *skip)
 {
-	PyObject *list, *elem, *stat, *ret = NULL;
+	PyObject *list, *elem, *stat = NULL, *ret = NULL;
 	char fullpath[PATH_MAX + 10];
 	int kind, err;
 	struct stat st;
@@ -369,6 +369,7 @@
 			elem = Py_BuildValue("si", ent->d_name, kind);
 		if (!elem)
 			goto error;
+		stat = NULL;
 
 		PyList_Append(list, elem);
 		Py_DECREF(elem);
@@ -379,6 +380,7 @@
 
 error:
 	Py_DECREF(list);
+	Py_XDECREF(stat);
 error_list:
 	closedir(dir);
 error_dir: