# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1518462748 18000
# Node ID 48b592d986e7eb169fe59e5c99661e8a257ba0d7
# Parent  59adb3051718ad699965943f2fa95e77c8f9896c
narrowrevlog: add what little I can remember about rename filtering

Differential Revision: https://phab.mercurial-scm.org/D2188

diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py
--- a/hgext/narrow/narrowrevlog.py
+++ b/hgext/narrow/narrowrevlog.py
@@ -139,6 +139,12 @@
 def makenarrowfilelog(fl, narrowmatch):
     class narrowfilelog(fl.__class__):
         def renamed(self, node):
+            # Renames that come from outside the narrowspec are
+            # problematic at least for git-diffs, because we lack the
+            # base text for the rename. This logic was introduced in
+            # 3cd72b1 of narrowhg (authored by martinvonz, reviewed by
+            # adgar), but that revision doesn't have any additional
+            # commentary on what problems we can encounter.
             m = super(narrowfilelog, self).renamed(node)
             if m and not narrowmatch(m[0]):
                 return None