# HG changeset patch # User jwe # Date 813485534 0 # Node ID ffee86c3793172d852e8f58b9da21e03c8954528 # Parent 27a03373de4150e889934daeafba168ce4152fd0 [project @ 1995-10-12 08:08:25 by jwe] diff --git a/liboctave/Array-idx.h b/liboctave/Array-idx.h --- a/liboctave/Array-idx.h +++ b/liboctave/Array-idx.h @@ -536,13 +536,15 @@ } else if (rhs_nr == 1 && rhs_nc == 1) { + RT scalar = rhs.elem (0, 0); + for (int j = 0; j < m; j++) { int jj = idx_j.elem (j); for (int i = 0; i < n; i++) { int ii = idx_i.elem (i); - lhs.elem (ii, jj) = rhs.elem (0, 0); + lhs.elem (ii, jj) = scalar; } } } diff --git a/liboctave/Array.cc b/liboctave/Array.cc --- a/liboctave/Array.cc +++ b/liboctave/Array.cc @@ -395,6 +395,26 @@ delete old_rep; } +template +Array2& +Array2::insert (const Array2& a, int r, int c) +{ + int a_rows = a.rows (); + int a_cols = a.cols (); + if (r < 0 || r + a_rows - 1 > rows () + || c < 0 || c + a_cols - 1 > cols ()) + { + (*current_liboctave_error_handler) ("range error for insert"); + return *this; + } + + for (int j = 0; j < a_cols; j++) + for (int i = 0; i < a_rows; i++) + elem (r+i, c+j) = a.elem (i, j); + + return *this; +} + // Three dimensional array class. template diff --git a/liboctave/Array.h b/liboctave/Array.h --- a/liboctave/Array.h +++ b/liboctave/Array.h @@ -330,6 +330,8 @@ void resize (int n, int m); void resize (int n, int m, const T& val); + Array2& insert (const Array2& a, int r, int c); + #ifdef HEAVYWEIGHT_INDEXING void maybe_delete_elements (idx_vector& i, idx_vector& j); diff --git a/liboctave/CMatrix.cc b/liboctave/CMatrix.cc --- a/liboctave/CMatrix.cc +++ b/liboctave/CMatrix.cc @@ -191,18 +191,7 @@ ComplexMatrix& ComplexMatrix::insert (const ComplexMatrix& a, int r, int c) { - int a_nr = a.rows (); - int a_nc = a.cols (); - if (r < 0 || r + a_nr - 1 > rows () || c < 0 || c + a_nc - 1 > cols ()) - { - (*current_liboctave_error_handler) ("range error for insert"); - return *this; - } - - for (int j = 0; j < a_nc; j++) - for (int i = 0; i < a_nr; i++) - elem (r+i, c+j) = a.elem (i, j); - + Array2::insert (a, r, c); return *this; } diff --git a/liboctave/dMatrix.cc b/liboctave/dMatrix.cc --- a/liboctave/dMatrix.cc +++ b/liboctave/dMatrix.cc @@ -111,19 +111,7 @@ Matrix& Matrix::insert (const Matrix& a, int r, int c) { - int a_rows = a.rows (); - int a_cols = a.cols (); - if (r < 0 || r + a_rows - 1 > rows () - || c < 0 || c + a_cols - 1 > cols ()) - { - (*current_liboctave_error_handler) ("range error for insert"); - return *this; - } - - for (int j = 0; j < a_cols; j++) - for (int i = 0; i < a_rows; i++) - elem (r+i, c+j) = a.elem (i, j); - + Array2::insert (a, r, c); return *this; }