changeset 13671:228e72ae2254

fts: don't operate on an invalid file descriptor after failed dup * lib/fts.c (fts_build): Don't call set_cloexec_flag on a negative file descriptor.
author Jim Meyering <meyering@redhat.com>
date Mon, 13 Sep 2010 07:29:18 +0200
parents a930c356f503
children e07237e12926
files ChangeLog lib/fts.c
diffstat 2 files changed, 8 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-09-13  Jim Meyering  <meyering@redhat.com>
+
+	fts: don't operate on an invalid file descriptor after failed dup
+	* lib/fts.c (fts_build): Don't call set_cloexec_flag on a
+	negative file descriptor.
+
 2010-09-12  Paul Eggert  <eggert@cs.ucla.edu>
 
 	savedir: add streamsavedir, deprecate fdsavedir
--- a/lib/fts.c
+++ b/lib/fts.c
@@ -1305,7 +1305,8 @@
                 if (ISSET(FTS_CWDFD) && 0 <= dir_fd)
                   {
                     dir_fd = dup (dir_fd);
-                    set_cloexec_flag (dir_fd, true);
+                    if (0 <= dir_fd)
+                      set_cloexec_flag (dir_fd, true);
                   }
                 if (dir_fd < 0 || fts_safe_changedir(sp, cur, dir_fd, NULL)) {
                         if (nlinks && type == BREAD)