# HG changeset patch # User Eric Blake # Date 1316190493 21600 # Node ID 44827bcbe6ca469770d3920c33fc5d084f3febc0 # Parent 04a6b94f5530288c832ed160e0349d9578e71a5c test-fsync: enhance tests This test failed to compile on mingw, which lacks ENOTSUP. Furthermore, it wasn't testing POSIX behavior on invalid fds. * modules/fsync-tests (Depends-on): Add errno, for mingw. * tests/test-fsync.c (main): Enhance test. Signed-off-by: Eric Blake diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2011-09-16 Eric Blake + + test-fsync: enhance tests + * modules/fsync-tests (Depends-on): Add errno, for mingw. + * tests/test-fsync.c (main): Enhance test. + 2011-09-15 Bruno Haible Support for MSVC compiler: Ensure ssize_t gets defined. diff --git a/modules/fsync-tests b/modules/fsync-tests --- a/modules/fsync-tests +++ b/modules/fsync-tests @@ -4,6 +4,7 @@ tests/macros.h Depends-on: +errno configure.ac: diff --git a/tests/test-fsync.c b/tests/test-fsync.c --- a/tests/test-fsync.c +++ b/tests/test-fsync.c @@ -32,13 +32,16 @@ int fd; const char *file = "test-fsync.txt"; - if (fsync (0) != 0) + if (fsync (STDOUT_FILENO) != 0) { ASSERT (errno == EINVAL /* POSIX */ || errno == ENOTSUP /* seen on MacOS X 10.5 */ || errno == EBADF /* seen on AIX 7.1 */ - ); + ); } + errno = 0; + ASSERT (fsync (-1) == -1); + ASSERT (errno == EBADF); fd = open (file, O_WRONLY|O_CREAT|O_TRUNC, 0644); ASSERT (0 <= fd); ASSERT (write (fd, "hello", 5) == 5);