# HG changeset patch # User Bruno Haible # Date 1232578558 -3600 # Node ID 784aa6a7ca437e7ee7a6ef21b4a0850454e6aa46 # Parent 42d47e0b9b24c22f599a28269b54aea9851438c3 Improve error checking of c_strtod call. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2009-01-21 Bruno Haible + + * lib/getloadavg.c (getloadavg): Check c_strtod result against error + conditions other than overflow. + 2009-01-21 Bruno Haible * lib/c-strtod.c: Include errno.h. diff --git a/lib/getloadavg.c b/lib/getloadavg.c --- a/lib/getloadavg.c +++ b/lib/getloadavg.c @@ -1,8 +1,8 @@ /* Get the system load averages. Copyright (C) 1985, 1986, 1987, 1988, 1989, 1991, 1992, 1993, 1994, - 1995, 1997, 1999, 2000, 2003, 2004, 2005, 2006, 2007, 2008 Free Software - Foundation, Inc. + 1995, 1997, 1999, 2000, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free + Software Foundation, Inc. NOTE: The canonical source of this file is maintained with gnulib. Bugs can be reported to bug-gnulib@gnu.org. @@ -621,8 +621,11 @@ for (elem = 0; elem < nelem; elem++) { char *endptr; - double d = c_strtod (ptr, &endptr); - if (ptr == endptr) + double d; + + errno = 0; + d = c_strtod (ptr, &endptr); + if (ptr == endptr || (d == 0 && errno != 0)) { if (elem == 0) return -1;