# HG changeset patch # User Jim Meyering # Date 1236089265 -3600 # Node ID a1d8806893b5aeeda6d090b43903d7e0134e3a0d # Parent e12ffbb3ba4bcddd2b3740d0e800a225b72c44e5 unlinkdir: cannot_unlink_dir may modify process state * lib/unlinkdir.c (cannot_unlink_dir): Add a comment warning that it's neither thread-safe nor appropriate for use in a library. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-03-03 Jim Meyering + + unlinkdir: cannot_unlink_dir may modify process state + * lib/unlinkdir.c (cannot_unlink_dir): Add a comment warning that + it's neither thread-safe nor appropriate for use in a library. + 2009-03-03 Eric Blake test-closein: silence test under Darwin diff --git a/lib/unlinkdir.c b/lib/unlinkdir.c --- a/lib/unlinkdir.c +++ b/lib/unlinkdir.c @@ -1,6 +1,6 @@ /* unlinkdir.c - determine (and maybe change) whether we can unlink directories - Copyright (C) 2005, 2006 Free Software Foundation, Inc. + Copyright (C) 2005-2006, 2009 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -30,7 +30,11 @@ /* Return true if we cannot unlink directories, false if we might be able to unlink directories. If possible, tell the kernel we don't - want to be able to unlink directories, so that we can return true. */ + want to be able to unlink directories, so that we can return true. + + Note: this function may modify the process privilege set, to remove + the PRIV_SYS_LINKDIR privilege, so is neither thread-safe, nor + appropriate for use in a library. */ bool cannot_unlink_dir (void)