# HG changeset patch # User Eric Blake # Date 1250187107 21600 # Node ID dcb923072f09c57767056df33bbf1f2fc0b348de # Parent 69c3e283e8de9cf3d8dc060f2c3785f2e257c6fa test-dup2: fix bad assumption * tests/test-dup2.c (main): Tolerate leaked fds from environment. Reported by Peter Breitenlohner . Signed-off-by: Eric Blake diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2009-08-13 Eric Blake + test-dup2: fix bad assumption + * tests/test-dup2.c (main): Tolerate leaked fds from environment. + Reported by Peter Breitenlohner . + test-version-etc: fix CRLF portability issue * tests/test-version-etc.sh: Use tr, not sed, as not all sed recognize \r. diff --git a/tests/test-dup2.c b/tests/test-dup2.c --- a/tests/test-dup2.c +++ b/tests/test-dup2.c @@ -67,8 +67,12 @@ char buffer[1]; int fd = open (file, O_CREAT | O_RDWR, 0600); - ASSERT (0 <= fd); + /* Assume std descriptors were provided by invoker. */ + ASSERT (STDERR_FILENO < fd); ASSERT (is_open (fd)); + /* Ignore any other fd's leaked into this process. */ + close (fd + 1); + close (fd + 2); ASSERT (!is_open (fd + 1)); ASSERT (!is_open (fd + 2));