changeset 15320:15f2ff83a46c

syntax-check: keep one maint.mk rule in sync with its header * Makefile (sc_check_sym_list): Add a rule to prevent a repeat of the bug Eric has just fixed, with today's commit 25e4c2ec. I prefer to avoid temporary files here, so use <(...), but that is not supported by /bin/sh, so... (SHELL): Define to /bin/bash.
author Jim Meyering <meyering@redhat.com>
date Fri, 24 Jun 2011 20:52:00 +0200
parents cf58fc92428c
children eada9764cc6a
files ChangeLog Makefile
diffstat 2 files changed, 22 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-06-24  Jim Meyering  <meyering@redhat.com>
+
+	syntax-check: keep one maint.mk rule in sync with its header
+	* Makefile (sc_check_sym_list): Add a rule to prevent a repeat
+	of the bug Eric has just fixed, with today's commit 25e4c2ec.
+	I prefer to avoid temporary files here, so use <(...), but that
+	is not supported by /bin/sh, so...
+	(SHELL): Define to /bin/bash.
+
 2011-06-24  Eric Blake  <eblake@redhat.com>
 
 	maint.mk: update sc_prohibit_intprops_without_use
--- a/Makefile
+++ b/Makefile
@@ -8,6 +8,9 @@
 # This Makefile requires the use of GNU make.  Some targets require
 # that you have tools like git, makeinfo and cppi installed.
 
+# Required for the use of <(...) below.
+SHELL=/bin/bash
+
 # Produce some files that are not stored in the repository.
 all:
 
@@ -95,6 +98,16 @@
           | grep -v '/getloadavg\.c$$' \
           | xargs cppi -c
 
+# Ensure that the list of symbols checked for by the
+# sc_prohibit_intprops_without_use rule match those in the actual file.
+# Extract the symbols from the .h file and compare with the list of
+# symbols extracted from the rule in maint.mk.
+sc_check_sym_list:
+	i=lib/intprops.h; \
+	diff -u <(perl -lne '/^# *define ([A-Z]\w+)\(/ and print $$1' $$i|fmt) \
+	  <(sed -n /^_intprops_name/,/^_intprops_syms_re/p top/maint.mk \
+            |sed '/^_/d;s/^  //;s/	*\\$$//')
+
 # Regenerate some files that are stored in the repository.
 regen: MODULES.html