changeset 16899:2311514e2d84

maint.mk: prohibit common grammar error: "all these" * top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to the list of prohibited word sequences. It should be "all of these". * lib/tempname.c (__gen_tempname): Fix one of them.
author Jim Meyering <meyering@redhat.com>
date Sun, 10 Jun 2012 21:49:59 +0200
parents f1a0ea1e49d3
children 84563bab7ebd
files ChangeLog lib/tempname.c top/maint.mk
diffstat 3 files changed, 9 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2012-06-10  Jim Meyering  <meyering@redhat.com>
+
+	maint.mk: prohibit common grammar error: "all these"
+	* top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to
+	the list of prohibited word sequences.  It should be "all of these".
+	* lib/tempname.c (__gen_tempname): Fix one of them.
+
 2012-06-07  Akim Demaille  <akim@lrde.epita.fr>
 
 	do-release-commit-and-tag: support VPATH builds
--- a/lib/tempname.c
+++ b/lib/tempname.c
@@ -207,7 +207,7 @@
   /* A lower bound on the number of temporary files to attempt to
      generate.  The maximum total number of temporary file names that
      can exist for a given template is 62**6.  It should never be
-     necessary to try all these combinations.  Instead if a reasonable
+     necessary to try all of these combinations.  Instead if a reasonable
      number of names is tried (we define reasonable as 62**3) fail to
      give the system administrator the chance to remove the problems.  */
 #define ATTEMPTS_MIN (62 * 62 * 62)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -948,7 +948,7 @@
 bad_xref_re_ ?= (?:[\w,:;] +|(?:see|also)\s+)\@xref\{
 bad_pxref_re_ ?= (?:[.!?]|(?:see|also))\s+\@pxref\{
 prohibit_undesirable_word_seq_RE_ ?=					\
-  /(?:\bcan\s+not\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims
+  /(?:\bcan\s+not\b|\ball these\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims
 prohibit_undesirable_word_seq_ =					\
     -e 'while ($(prohibit_undesirable_word_seq_RE_))'			\
     $(perl_filename_lineno_text_)