Mercurial > hg > octave-lojdl > gnulib-hg
changeset 13046:81c0a49eb40d
pt_chown: Don't depend on GPLed modules.
| author | Bruno Haible <bruno@clisp.org> |
|---|---|
| date | Wed, 24 Mar 2010 01:08:56 +0100 |
| parents | 04f53e0b1556 |
| children | 83b732e6d2c4 |
| files | ChangeLog lib/pt_chown.c modules/pt_chown |
| diffstat | 3 files changed, 10 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2010-03-23 Bruno Haible <bruno@clisp.org> + + pt_chown: Don't depend on GPLed modules. + * lib/pt_chown.c: Don't include idpriv.h. + (main): Don't drop privileges. + * modules/pt_chown (Depends-on): Remove idpriv-drop. + Reported by Simon Josefsson. + 2010-03-24 Simon Josefsson <simon@josefsson.org> * top/maint.mk (sc_texinfo_acronym): Add rule, based on
--- a/lib/pt_chown.c +++ b/lib/pt_chown.c @@ -25,7 +25,6 @@ #include <sys/stat.h> #include <unistd.h> -#include "idpriv.h" #include "pty-private.h" /* For security reasons, we try to minimize the dependencies on libraries @@ -83,9 +82,8 @@ return do_pt_chown (); } - /* We aren't going to be using privileges, so drop them right now. */ - if (idpriv_drop () < 0) - return EXIT_FAILURE; + /* It would be possible to drop setuid/setgid privileges here. But it is not + really needed, since the code below only calls strcmp and [f]printf. */ { int do_help = 0;