changeset 13629:978ed1b129fb

tests: prohibit augmenting PATH via TESTS_ENVIRONMENT * Makefile (sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT): New rule.
author Jim Meyering <meyering@redhat.com>
date Sat, 04 Sep 2010 12:45:22 +0200
parents b8b731ae72a8
children dbece3bf692b
files ChangeLog Makefile
diffstat 2 files changed, 16 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-09-04  Jim Meyering  <meyering@redhat.com>
+
+	tests: prohibit augmenting PATH via TESTS_ENVIRONMENT
+	* Makefile (sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT): New rule.
+
 2010-09-04  Bruno Haible  <bruno@clisp.org>
 
 	strdup: Fix compilation error in C++ mode.
--- a/Makefile
+++ b/Makefile
@@ -13,7 +13,9 @@
 	cd doc && $(MAKE) $@ && $(MAKE) mostlyclean
 
 # Perform some platform independent checks on the gnulib code.
-check: sc_prefer_ac_check_funcs_once
+check: \
+  sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT			\
+  sc_prefer_ac_check_funcs_once
 
 sc_prefer_ac_check_funcs_once:
 	if test -d .git; then						\
@@ -22,6 +24,14 @@
                    in modules/ 1>&2; exit 1; } || :			\
 	else :; fi
 
+sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT:
+	if test -d .git; then						\
+          url=http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/22874;	\
+	  git grep '^[	 ]*TESTS_ENVIRONMENT += PATH=' modules		\
+	    && { printf '%s\n' 'Do not augment PATH via TESTS_ENVIRONMENT;' \
+		 "  see <$$url>" 1>&2; exit 1; } || :			\
+	else :; fi
+
 # Regenerate some files that are stored in the repository.
 regen: MODULES.html