Mercurial > hg > octave-lojdl > gnulib-hg
changeset 13832:992d47604da1
tests: fix compiler warnings
Detected by icc. The first three files are real test bugs, the
last merely silences a warning about mixing an int with an enum type.
* tests/test-getopt.h (test_getopt): Fix condition.
* tests/test-getopt_long.h (test_getopt_long): Likewise.
* tests/test-pipe2.c (main): Likewise.
* tests/test-quotearg-simple.c (main): Avoid icc warning.
Signed-off-by: Eric Blake <eblake@redhat.com>
| author | Eric Blake <eblake@redhat.com> |
|---|---|
| date | Wed, 03 Nov 2010 16:48:56 -0600 |
| parents | a1a57873cef7 |
| children | c58f1396894e |
| files | ChangeLog tests/test-getopt.h tests/test-getopt_long.h tests/test-pipe2.c tests/test-quotearg-simple.c |
| diffstat | 5 files changed, 11 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2010-11-03 Eric Blake <eblake@redhat.com> + tests: fix compiler warnings + * tests/test-getopt.h (test_getopt): Fix condition. + * tests/test-getopt_long.h (test_getopt_long): Likewise. + * tests/test-pipe2.c (main): Likewise. + * tests/test-quotearg-simple.c (main): Avoid icc warning. + utimens: fix broken m4 test * m4/utimens.m4 (gl_UTIMENS): Include correct headers.
--- a/tests/test-getopt.h +++ b/tests/test-getopt.h @@ -1187,7 +1187,7 @@ ASSERT (q_value == NULL); ASSERT (non_options_count == 0); ASSERT (unrecognized == 0); - ASSERT (optind = 1); + ASSERT (optind == 1); ASSERT (!output); } #endif /* GNULIB_TEST_GETOPT_GNU */
--- a/tests/test-getopt_long.h +++ b/tests/test-getopt_long.h @@ -1747,7 +1747,7 @@ ASSERT (q_value == NULL); ASSERT (non_options_count == 0); ASSERT (unrecognized == 0); - ASSERT (optind = 1); + ASSERT (optind == 1); } /* Check that the '+' flag has to come first. */
--- a/tests/test-pipe2.c +++ b/tests/test-pipe2.c @@ -117,8 +117,8 @@ ASSERT (fd[0] >= 0); ASSERT (fd[1] >= 0); ASSERT (fd[0] != fd[1]); - ASSERT (is_open (fd[0]) >= 0); - ASSERT (is_open (fd[1]) >= 0); + ASSERT (is_open (fd[0])); + ASSERT (is_open (fd[1])); if (use_cloexec) { ASSERT (is_cloexec (fd[0]));
--- a/tests/test-quotearg-simple.c +++ b/tests/test-quotearg-simple.c @@ -244,7 +244,7 @@ ASSERT (!isprint ('\033')); for (i = literal_quoting_style; i <= clocale_quoting_style; i++) { - set_quoting_style (NULL, i); + set_quoting_style (NULL, (enum quoting_style) i); compare_strings (use_quotearg_buffer, &results_g[i].group1, ascii_only); compare_strings (use_quotearg, &results_g[i].group2, ascii_only); if (i == c_quoting_style)