Mercurial > hg > octave-lojdl > gnulib-hg

changeset 11889:ba2a880e1278

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
quotearg: fix right quote escaping when it's in quote_these_too * lib/quotearg.c (quotearg_buffer_restyled): Upon seeing a right quote, be sure to prepend only one backslash. * tests/test-quotearg.c (use_quote_double_quotes): New function. (main): Test it.
author Joel E. Denny <jdenny@clemson.edu>
date Sat, 22 Aug 2009 20:26:46 -0400
parents bef110831f24
children 96999501e6ed
files ChangeLog lib/quotearg.c tests/test-quotearg.c
diffstat 3 files changed, 30 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-08-22  Joel E. Denny  <jdenny@clemson.edu>
+
+	quotearg: fix right quote escaping when it's in quote_these_too
+	* lib/quotearg.c (quotearg_buffer_restyled): Upon seeing a right
+	quote, be sure to prepend only one backslash.
+	* tests/test-quotearg.c (use_quote_double_quotes): New function.
+	(main): Test it.
+
 2009-08-22  Joel E. Denny  <jdenny@clemson.edu>
 
 	quotearg-tests: test escaping of embedded locale quotes
--- a/lib/quotearg.c
+++ b/lib/quotearg.c
@@ -280,6 +280,7 @@
     {
       unsigned char c;
       unsigned char esc;
+      bool is_right_quote = false;
 
       if (backslash_escapes
 	  && quote_string_len
@@ -288,7 +289,7 @@
 	{
 	  if (elide_outer_quotes)
 	    goto force_outer_quoting_style;
-	  STORE ('\\');
+	  is_right_quote = true;
 	}
 
       c = arg[i];
@@ -521,6 +522,11 @@
 			STORE ('0' + ((c >> 3) & 7));
 			c = '0' + (c & 7);
 		      }
+		    else if (is_right_quote)
+		      {
+			STORE ('\\');
+			is_right_quote = false;
+		      }
 		    if (ilim <= i + 1)
 		      break;
 		    STORE (c);
@@ -534,7 +540,8 @@
 
       if (! ((backslash_escapes || elide_outer_quotes)
 	     && quote_these_too
-	     && quote_these_too[c / INT_BITS] & (1 << (c % INT_BITS))))
+	     && quote_these_too[c / INT_BITS] & (1 << (c % INT_BITS)))
+	  && !is_right_quote)
 	goto store_c;
 
     store_escape:
--- a/tests/test-quotearg.c
+++ b/tests/test-quotearg.c
@@ -264,6 +264,15 @@
 }
 
 static char *
+use_quote_double_quotes (const char *str, size_t *len)
+{
+  char *p = *len == SIZE_MAX ? quotearg_char (str, '"')
+                               : quotearg_char_mem (str, *len, '"');
+  *len = strlen (p);
+  return p;
+}
+
+static char *
 use_quotearg_colon (const char *str, size_t *len)
 {
   char *p = (*len == SIZE_MAX ? quotearg_colon (str)
@@ -287,6 +296,8 @@
       set_quoting_style (NULL, i);
       compare_strings (use_quotearg_buffer, &results_g[i].group1);
       compare_strings (use_quotearg, &results_g[i].group2);
+      if (i == c_quoting_style)
+        compare_strings (use_quote_double_quotes, &results_g[i].group2);
       compare_strings (use_quotearg_colon, &results_g[i].group3);
     }
 
@@ -301,12 +312,14 @@
 	  == QA_ELIDE_NULL_BYTES);
   compare_strings (use_quotearg_buffer, &flag_results[1].group1);
   compare_strings (use_quotearg, &flag_results[1].group2);
+  compare_strings (use_quote_double_quotes, &flag_results[1].group2);
   compare_strings (use_quotearg_colon, &flag_results[1].group3);
 
   ASSERT (set_quoting_flags (NULL, QA_SPLIT_TRIGRAPHS)
 	  == QA_ELIDE_OUTER_QUOTES);
   compare_strings (use_quotearg_buffer, &flag_results[2].group1);
   compare_strings (use_quotearg, &flag_results[2].group2);
+  compare_strings (use_quote_double_quotes, &flag_results[2].group2);
   compare_strings (use_quotearg_colon, &flag_results[2].group3);
 
   ASSERT (set_quoting_flags (NULL, 0) == QA_SPLIT_TRIGRAPHS);