Mercurial > hg > octave-lyh
view liboctave/array/Array-b.cc @ 16169:0303fda3e929
Fix range behavior with -0 endpoints (bug #38423)
* libinterp/interpfcn/pr-output.cc(octave_print_internal): print base
or limit of range rather than using expression base+i*increment
which can destroy the signbit of base/limit.
* liboctave/array/Range.cc(Range constructor): Move trivial 2-line constructor
to .h file.
* liboctave/array/Range.cc(matrix_value, checkelem): Return base for first
element of array. Return limit of range for end of array if appropriate.
* liboctave/array/Range.cc(elem): Move function from Range.h Return base for
first element of array. Return limit of range for end of array if appropriate.
* liboctave/array/Range.cc(_rangeindex_helper, index): Return base for first
element of array. Return limit of range for end of array if appropriate.
* liboctave/array/Range.cc(min, max): Use '<=' or '>=' tests to
return base or limit if appropriate.
* liboctave/array/Range.cc(is_sorted): Place more common test first in
if/else if/else tree.
* liboctave/array/Range.cc(operator <<): Return base for first
element of array. Return limit of range for end of array if appropriate.
liboctave/array/Range.h(Range constructor): Put trivial 2-line constructor
in .h file.
liboctave/array/Range.h(elem): Move function which has become more complicated
to Range.cc.
* test/range.tst: Add %!tests for corner cases of base and limit of range.
author | Rik <rik@octave.org> |
---|---|
date | Fri, 01 Mar 2013 14:06:02 -0800 |
parents | 648dabbb4c6b |
children |
line wrap: on
line source
/* Copyright (C) 1996-2012 John W. Eaton This file is part of Octave. Octave is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. Octave is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with Octave; see the file COPYING. If not, see <http://www.gnu.org/licenses/>. */ #ifdef HAVE_CONFIG_H #include <config.h> #endif // Instantiate Arrays of bool values. #include "Array.h" #include "Array.cc" #define INLINE_ASCENDING_SORT #define INLINE_DESCENDING_SORT #include "oct-sort.cc" // Specialize bool sorting (aka stable partitioning). template<bool desc> static void do_bool_partition (bool *data, octave_idx_type nel) { octave_idx_type k = 0; for (octave_idx_type i = 0; i < nel; i++) if (data[i] == desc) data[k++] = desc; for (octave_idx_type i = k; i < nel; i++) data[i] = ! desc; } template<bool desc> static void do_bool_partition (bool *data, octave_idx_type *idx, octave_idx_type nel) { // FIXME: This is essentially a simple bucket sort. // Can it be efficiently done by std::partition? OCTAVE_LOCAL_BUFFER (octave_idx_type, jdx, nel); octave_idx_type k = 0, l = 0; for (octave_idx_type i = 0; i < nel; i++) { if (data[i] == desc) { data[k] = desc; idx[k++] = idx[i]; } else jdx[l++] = idx[i]; } for (octave_idx_type i = k; i < nel; i++) { data[i] = ! desc; idx[i] = jdx[i-k]; } } template <> template <> void octave_sort<bool>::sort (bool *data, octave_idx_type nel, std::less<bool>) { do_bool_partition<false> (data, nel); } template <> template <> void octave_sort<bool>::sort (bool *data, octave_idx_type nel, std::greater<bool>) { do_bool_partition<true> (data, nel); } template <> template <> void octave_sort<bool>::sort (bool *data, octave_idx_type *idx, octave_idx_type nel, std::less<bool>) { do_bool_partition<false> (data, idx, nel); } template <> template <> void octave_sort<bool>::sort (bool *data, octave_idx_type *idx, octave_idx_type nel, std::greater<bool>) { do_bool_partition<true> (data, idx, nel); } INSTANTIATE_ARRAY_SORT (bool); INSTANTIATE_ARRAY (bool, OCTAVE_API); template OCTAVE_API std::ostream& operator << (std::ostream&, const Array<bool>&); #include "DiagArray2.h" #include "DiagArray2.cc" template class OCTAVE_API DiagArray2<bool>;