# HG changeset patch # User Jim Meyering # Date 1233131252 -3600 # Node ID 015e36a5b521af5cc8f484fc9f78016e0aa0e6b6 # Parent 635b97a3eef213afe856dbd676b657884c560b79 useless-if-before-free: correction It does *not* recognize "if (p != (void*)0) free(p);", since the RHS in this example may not contain ")" diff --git a/build-aux/useless-if-before-free b/build-aux/useless-if-before-free --- a/build-aux/useless-if-before-free +++ b/build-aux/useless-if-before-free @@ -2,9 +2,9 @@ # Detect instances of "if (p) free (p);". # Likewise for "if (p != NULL) free (p);". And with braces. # Also detect "if (NULL != p) free (p);". -# And with 0 or "(void *)0" in place of NULL. +# And with 0 in place of NULL. -my $VERSION = '2009-01-28 08:16'; # UTC +my $VERSION = '2009-01-28 08:23'; # UTC # The definition above must lie within the first 8 lines in order # for the Emacs time-stamp write hook (at end) to update it. # If you change this file with Emacs, please let the write hook @@ -89,9 +89,7 @@ sub is_NULL ($) { my ($expr) = @_; - return ($expr eq 'NULL' - || $expr eq '0' - || $expr =~ /^\(\s*(char|void)\s*\*\s*\)\s*0$/); + return ($expr eq 'NULL' || $expr eq '0'); } {