# HG changeset patch # User Bruno Haible # Date 1209331818 -7200 # Node ID 2bff2d33e74d4d7ac7c1cbe7c821329ea0e0fcd4 # Parent 74f56586d150a45eed62091515a32ac9f3abdcd4 Add some comments. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2008-04-27 Bruno Haible + + * lib/rpmatch.c (rpmatch): Add some comments. + Reported by James Youngman . + 2008-04-27 Bruno Haible * m4/isnanl.m4 (gl_FUNC_ISNANL_WORKS): Also test the behaviour on diff --git a/lib/rpmatch.c b/lib/rpmatch.c --- a/lib/rpmatch.c +++ b/lib/rpmatch.c @@ -1,7 +1,7 @@ /* Determine whether string value is affirmation or negative response according to current locale's data. - Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006 Free Software + Copyright (C) 1996, 1998, 2000, 2002, 2003, 2006, 2008 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify @@ -61,6 +61,15 @@ /* Match against one of the response patterns, compiling the pattern first if necessary. */ + /* We get the patterns from a PO file. It would be possible to use + nl_langinfo (YESEXPR) instead of _("^[yY]"), and nl_langinfo (NOEXPR) + instead of _("^[nN]"), if we could assume that the system's locale + support is good. But this is not the case e.g. on Cygwin. The + localizations of gnulib.pot are of better quality in general. + Also, if we used locale info from non-free systems that don't have a + 'localedef' command, we would deprive the users of the freedom to + localize this pattern for their preferred language. */ + /* We cache the response patterns and compiled regexps here. */ static const char *yesexpr, *noexpr; static regex_t yesre, nore;