# HG changeset patch # User Jim Meyering # Date 1228672022 -3600 # Node ID f6d444835290b6ada982971d8df9beb1fbbeef1a # Parent b6d1276d462d8e553fee41aa335eb6a325635b1f posixtm.c: avoid a warning * lib/posixtm.c (posixtime): Don't initialize tm0. It's no longer needed to placate gcc4's -Wuninitialized, and the attempt to placate would elicit a new warning. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2008-12-07 Jim Meyering + posixtm.c: avoid a warning + * lib/posixtm.c (posixtime): Don't initialize tm0. + It's no longer needed to placate gcc4's -Wuninitialized, + and the attempt to placate would elicit a new warning. + unicodeio.c: mark unused parameters * lib/unicodeio.c (exit_failure_callback): Mark unused parameter. (fallback_failure_callback): Likewise. diff --git a/lib/posixtm.c b/lib/posixtm.c --- a/lib/posixtm.c +++ b/lib/posixtm.c @@ -186,15 +186,7 @@ bool posixtime (time_t *p, const char *s, unsigned int syntax_bits) { - struct tm tm0 -#ifdef lint - /* Placate gcc-4's -Wuninitialized. - posix_time_parse fails to set all of tm0 only when it returns - nonzero (due to year() returning nonzero), and in that case, - this code doesn't use the tm0 at all. */ - = { 0, } -#endif - ; + struct tm tm0; struct tm tm1; struct tm const *tm; time_t t;