changeset 7900:2843623a4ec4

Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys". * modules/sys_stat (Makefile.am): Use "$(MKDIR_P) sys", rather than the race-prone "test -d sys || mkdir sys". (configure.ac): Use AC_PROG_MKDIR_P. * modules/sys_select: Likewise. * modules/sys_socket: Likewise. * modules/sys_time: Likewise.
author Jim Meyering <jim@meyering.net>
date Thu, 18 Jan 2007 16:19:13 +0000
parents 8d0b7e3be0d2
children 1b1117096a35
files ChangeLog modules/sys_select modules/sys_socket modules/sys_stat modules/sys_time
diffstat 5 files changed, 18 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2007-01-18  Jim Meyering  <jim@meyering.net>
+
+	Use "$(MKDIR_P) sys", not race-prone "test -d sys || mkdir sys".
+	* modules/sys_stat (Makefile.am): Use "$(MKDIR_P) sys", rather
+	than the race-prone "test -d sys || mkdir sys".
+	(configure.ac): Use AC_PROG_MKDIR_P.
+	* modules/sys_select: Likewise.
+	* modules/sys_socket: Likewise.
+	* modules/sys_time: Likewise.
+
 2007-01-18  Eric Blake  <ebb9@byu.net>
 
 	* m4/gettimeofday.m4 (gl_GETTIMEOFDAY_REPLACE_LOCALTIME): Also
--- a/modules/sys_select
+++ b/modules/sys_select
@@ -9,6 +9,7 @@
 
 configure.ac:
 gl_HEADER_SYS_SELECT
+AC_PROG_MKDIR_P
 
 Makefile.am:
 BUILT_SOURCES += $(SYS_SELECT_H)
@@ -16,7 +17,7 @@
 # We need the following in order to create <sys/select.h> when the system
 # doesn't have one that works with the given compiler.
 sys/select.h:
-	test -d sys || mkdir sys
+	$(MKDIR_P) sys
 	rm -f $@-t $@
 	{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
 	  echo '#include <sys/socket.h>'; \
--- a/modules/sys_socket
+++ b/modules/sys_socket
@@ -10,6 +10,7 @@
 
 configure.ac:
 gl_HEADER_SYS_SOCKET
+AC_PROG_MKDIR_P
 
 Makefile.am:
 BUILT_SOURCES += $(SYS_SOCKET_H)
@@ -17,7 +18,7 @@
 # We need the following in order to create <sys/socket.h> when the system
 # doesn't have one that works with the given compiler.
 sys/socket.h: socket_.h
-	test -d sys || mkdir sys
+	$(MKDIR_P) sys
 	{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
 	  cat $(srcdir)/socket_.h; \
 	} > $@-t
--- a/modules/sys_stat
+++ b/modules/sys_stat
@@ -10,6 +10,7 @@
 
 configure.ac:
 gl_HEADER_SYS_STAT_H
+AC_PROG_MKDIR_P
 
 Makefile.am:
 BUILT_SOURCES += $(SYS_STAT_H)
@@ -17,7 +18,7 @@
 # We need the following in order to create <sys/stat.h> when the system
 # has one that is incomplete.
 sys/stat.h: stat_.h
-	test -d sys || mkdir sys
+	$(MKDIR_P) sys
 	rm -f $@-t $@
 	{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
 	  sed -e 's|@''ABSOLUTE_SYS_STAT_H''@|$(ABSOLUTE_SYS_STAT_H)|g' \
--- a/modules/sys_time
+++ b/modules/sys_time
@@ -10,6 +10,7 @@
 
 configure.ac:
 gl_HEADER_SYS_TIME_H
+AC_PROG_MKDIR_P
 
 Makefile.am:
 BUILT_SOURCES += sys/time.h
@@ -17,7 +18,7 @@
 # We need the following in order to create <sys/time.h> when the system
 # doesn't have one that works with the given compiler.
 sys/time.h: sys_time_.h
-	test -d sys || mkdir sys
+	$(MKDIR_P) sys
 	rm -f $@-t $@
 	{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
 	  sed -e 's/@''HAVE_SYS_TIME_H''@/$(HAVE_SYS_TIME_H)/g' \