Mercurial > hg > octave-lyh > gnulib-hg
changeset 16713:5090324ee0c8
gnulib-tool: fix imprecise comments w.r.t. an automake bug
It's not just Automake versions < 1.9b that creates an empty
pkgdatadir at installation time if pkgdata_DATA is specified
to empty; modern automake versions do this as well, at least
until automake 1.11.4 (not yet released at the moment of writing,
but soon to appear). That behaviour was generally considered a
feature rather than a bug, at least until this discussion:
<http://lists.gnu.org/archive/html/automake/2012-03/msg00014.html>
See also automake bugs #10997 and #11030.
* gnulib-tool (func_emit_lib_Makefile_am): Adjust comments. Add
reference to relevant automake bug numbers.
(func_emit_tests_Makefile_am): Likewise.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
author | Stefano Lattarini <stefano.lattarini@gmail.com> |
---|---|
date | Tue, 13 Mar 2012 10:51:08 +0100 |
parents | 6ba94155d867 |
children | 2e2bf6c7bf38 |
files | ChangeLog gnulib-tool |
diffstat | 2 files changed, 30 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +2012-03-23 Stefano Lattarini <stefano.lattarini@gmail.com> + + gnulib-tool: fix imprecise comments w.r.t. an automake bug + + It's not just Automake versions < 1.9b that creates an empty + pkgdatadir at installation time if pkgdata_DATA is specified + to empty; modern automake versions do this as well, at least + until automake 1.11.4 (not yet released at the moment of writing, + but soon to appear). That behaviour was generally considered a + feature rather than a bug, at least until this discussion: + <http://lists.gnu.org/archive/html/automake/2012-03/msg00014.html> + + See also automake bugs #10997 and #11030. + + * gnulib-tool (func_emit_lib_Makefile_am): Adjust comments. Add + reference to relevant automake bug numbers. + (func_emit_tests_Makefile_am): Likewise. + 2012-03-20 Reuben Thomas <rrt@sc3d.org> announce-gen: use Digest::SHA when possible
--- a/gnulib-tool +++ b/gnulib-tool @@ -3348,8 +3348,12 @@ echo "noinst_HEADERS =" echo "noinst_LIBRARIES =" echo "noinst_LTLIBRARIES =" - # Automake versions < 1.9b create an empty pkgdatadir at installation time - # if you specify pkgdata_DATA to empty. This is a workaround. + # Automake versions < 1.11.4 create an empty pkgdatadir at + # installation time if you specify pkgdata_DATA to empty. + # See automake bugs #10997 and #11030: + # * http://debbugs.gnu.org/10997 + # * http://debbugs.gnu.org/11030 + # So we need this workaround. if grep '^pkgdata_DATA *+=' "$tmp"/allsnippets > /dev/null; then echo "pkgdata_DATA =" fi @@ -3669,8 +3673,12 @@ echo "check_LIBRARIES = libtests.a" fi fi - # Automake versions < 1.9b create an empty pkgdatadir at installation time - # if you specify pkgdata_DATA to empty. This is a workaround. + # Automake versions < 1.11.4 create an empty pkgdatadir at + # installation time if you specify pkgdata_DATA to empty. + # See automake bugs #10997 and #11030: + # * http://debbugs.gnu.org/10997 + # * http://debbugs.gnu.org/11030 + # So we need this workaround. if grep '^pkgdata_DATA *+=' "$tmp"/main_snippets "$tmp"/longrunning_snippets > /dev/null; then echo "pkgdata_DATA =" fi