# HG changeset patch # User dbateman # Date 1189080525 0 # Node ID 83619ae96c1d707d2907b5af1542c56fe3837c51 # Parent f7bc1c20800ec43d198cdb40b8b1245e187b89cc [project @ 2007-09-06 12:08:44 by dbateman] diff --git a/liboctave/Array.cc b/liboctave/Array.cc --- a/liboctave/Array.cc +++ b/liboctave/Array.cc @@ -333,7 +333,7 @@ template T -Array::range_error (const char *fcn, const Array& ra_idx) const +Array::range_error (const char *fcn, const Array& ra_idx) const { std::ostringstream buf; @@ -358,7 +358,7 @@ template T& -Array::range_error (const char *fcn, const Array& ra_idx) +Array::range_error (const char *fcn, const Array& ra_idx) { std::ostringstream buf; diff --git a/liboctave/Array.h b/liboctave/Array.h --- a/liboctave/Array.h +++ b/liboctave/Array.h @@ -284,8 +284,8 @@ T range_error (const char *fcn, octave_idx_type i, octave_idx_type j, octave_idx_type k) const; T& range_error (const char *fcn, octave_idx_type i, octave_idx_type j, octave_idx_type k); - T range_error (const char *fcn, const Array& ra_idx) const; - T& range_error (const char *fcn, const Array& ra_idx); + T range_error (const char *fcn, const Array& ra_idx) const; + T& range_error (const char *fcn, const Array& ra_idx); // No checking, even for multiple references, ever. @@ -298,10 +298,10 @@ T& xelem (octave_idx_type i, octave_idx_type j, octave_idx_type k) { return xelem (i, dim2()*k+j); } T xelem (octave_idx_type i, octave_idx_type j, octave_idx_type k) const { return xelem (i, dim2()*k+j); } - T& xelem (const Array& ra_idx) + T& xelem (const Array& ra_idx) { return xelem (compute_index (ra_idx)); } - T xelem (const Array& ra_idx) const + T xelem (const Array& ra_idx) const { return xelem (compute_index (ra_idx)); } // FIXME -- would be nice to fix this so that we don't @@ -335,7 +335,7 @@ return elem (i, dim2()*k+j); } - T& checkelem (const Array& ra_idx) + T& checkelem (const Array& ra_idx) { octave_idx_type i = compute_index (ra_idx); @@ -355,19 +355,19 @@ T& elem (octave_idx_type i, octave_idx_type j, octave_idx_type k) { return elem (i, dim2()*k+j); } - T& elem (const Array& ra_idx) + T& elem (const Array& ra_idx) { return Array::elem (compute_index (ra_idx)); } #if defined (BOUNDS_CHECKING) T& operator () (octave_idx_type n) { return checkelem (n); } T& operator () (octave_idx_type i, octave_idx_type j) { return checkelem (i, j); } T& operator () (octave_idx_type i, octave_idx_type j, octave_idx_type k) { return checkelem (i, j, k); } - T& operator () (const Array& ra_idx) { return checkelem (ra_idx); } + T& operator () (const Array& ra_idx) { return checkelem (ra_idx); } #else T& operator () (octave_idx_type n) { return elem (n); } T& operator () (octave_idx_type i, octave_idx_type j) { return elem (i, j); } T& operator () (octave_idx_type i, octave_idx_type j, octave_idx_type k) { return elem (i, j, k); } - T& operator () (const Array& ra_idx) { return elem (ra_idx); } + T& operator () (const Array& ra_idx) { return elem (ra_idx); } #endif T checkelem (octave_idx_type n) const @@ -394,7 +394,7 @@ return Array::elem (i, Array::dim1()*k+j); } - T checkelem (const Array& ra_idx) const + T checkelem (const Array& ra_idx) const { octave_idx_type i = compute_index (ra_idx); @@ -410,19 +410,19 @@ T elem (octave_idx_type i, octave_idx_type j, octave_idx_type k) const { return elem (i, dim2()*k+j); } - T elem (const Array& ra_idx) const + T elem (const Array& ra_idx) const { return Array::elem (compute_index (ra_idx)); } #if defined (BOUNDS_CHECKING) T operator () (octave_idx_type n) const { return checkelem (n); } T operator () (octave_idx_type i, octave_idx_type j) const { return checkelem (i, j); } T operator () (octave_idx_type i, octave_idx_type j, octave_idx_type k) const { return checkelem (i, j, k); } - T operator () (const Array& ra_idx) const { return checkelem (ra_idx); } + T operator () (const Array& ra_idx) const { return checkelem (ra_idx); } #else T operator () (octave_idx_type n) const { return elem (n); } T operator () (octave_idx_type i, octave_idx_type j) const { return elem (i, j); } T operator () (octave_idx_type i, octave_idx_type j, octave_idx_type k) const { return elem (i, j, k); } - T operator () (const Array& ra_idx) const { return elem (ra_idx); } + T operator () (const Array& ra_idx) const { return elem (ra_idx); } #endif Array reshape (const dim_vector& new_dims) const; diff --git a/liboctave/ArrayN.h b/liboctave/ArrayN.h --- a/liboctave/ArrayN.h +++ b/liboctave/ArrayN.h @@ -87,10 +87,10 @@ ArrayN reshape (const dim_vector& new_dims) const { return Array::reshape (new_dims); } - ArrayN permute (const Array& vec, bool inv = false) const + ArrayN permute (const Array& vec, bool inv = false) const { return Array::permute (vec, inv); } - ArrayN ipermute (const Array& vec) const + ArrayN ipermute (const Array& vec) const { return Array::ipermute (vec); } void resize (const dim_vector& dv) diff --git a/liboctave/CMatrix.cc b/liboctave/CMatrix.cc --- a/liboctave/CMatrix.cc +++ b/liboctave/CMatrix.cc @@ -2761,14 +2761,14 @@ OCTAVE_QUIT; // construct balancing permutation vector - Array iperm (nc); + Array iperm (nc); for (octave_idx_type i = 0; i < nc; i++) iperm(i) = i; // initialize to identity permutation // leading permutations in forward order for (octave_idx_type i = 0; i < (ilo-1); i++) { - octave_idx_type swapidx = static_cast (dpermute(i)) - 1; + octave_idx_type swapidx = static_cast (dpermute(i)) - 1; octave_idx_type tmp = iperm(i); iperm(i) = iperm(swapidx); iperm(swapidx) = tmp; @@ -2777,14 +2777,14 @@ // trailing permutations must be done in reverse order for (octave_idx_type i = nc - 1; i >= ihi; i--) { - octave_idx_type swapidx = static_cast (dpermute(i)) - 1; + octave_idx_type swapidx = static_cast (dpermute(i)) - 1; octave_idx_type tmp = iperm(i); iperm(i) = iperm(swapidx); iperm(swapidx) = tmp; } // construct inverse balancing permutation vector - Array invpvec (nc); + Array invpvec (nc); for (octave_idx_type i = 0; i < nc; i++) invpvec(iperm(i)) = i; // Thanks to R. A. Lippert for this method diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog --- a/liboctave/ChangeLog +++ b/liboctave/ChangeLog @@ -1,3 +1,15 @@ +2007-09-06 David Bateman + + * Array.h (range_error, xelem, checkelem, elem, operator ()): + Modify use of Array to Array and adjust + where necessary. + * Array.cc (range_error): ditto. + * MArrayN.h (permute, ipermute): ditto. + * ArrayN.h (permute, ipermute): ditto. + * so-array.cc (streamoff_array::compute_index): ditto. + * so-array.h (compute_index): ditto. + * CMattrix.cc (ComplexMatrix::exmpm): ditto. + 2007-08-29 David Bateman * dSparse.cc (SparseMatrix SparseMatrix::inverse (MatrixType &, diff --git a/liboctave/MArrayN.h b/liboctave/MArrayN.h --- a/liboctave/MArrayN.h +++ b/liboctave/MArrayN.h @@ -90,10 +90,11 @@ MArrayN reshape (const dim_vector& new_dims) const { return ArrayN::reshape (new_dims); } - MArrayN permute (const Array& vec, bool inv = false) const + MArrayN permute (const Array& vec, + bool inv = false) const { return ArrayN::permute (vec, inv); } - MArrayN ipermute (const Array& vec) const + MArrayN ipermute (const Array& vec) const { return ArrayN::ipermute (vec); } MArrayN squeeze (void) const { return ArrayN::squeeze (); } diff --git a/liboctave/so-array.cc b/liboctave/so-array.cc --- a/liboctave/so-array.cc +++ b/liboctave/so-array.cc @@ -97,7 +97,7 @@ } octave_idx_type -streamoff_array::compute_index (Array& ra_idx, +streamoff_array::compute_index (Array& ra_idx, const dim_vector& dimensions) { return ::compute_index (ra_idx, dimensions); diff --git a/liboctave/so-array.h b/liboctave/so-array.h --- a/liboctave/so-array.h +++ b/liboctave/so-array.h @@ -82,7 +82,7 @@ boolNDArray all (int dim = -1) const; boolNDArray any (int dim = -1) const; - static octave_idx_type compute_index (Array& ra_idx, + static octave_idx_type compute_index (Array& ra_idx, const dim_vector& dimensions); static std::streamoff resize_fill_value (void) { return 0; } diff --git a/src/ChangeLog b/src/ChangeLog --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,11 @@ +2007-09-06 David Bateman + + * ov.cc (do_cat_op): Modify use of Array to + Array and adjust where necessary. + * ov.h (do_cat_op): ditto. + * data.cc (do_cat): ditto. + * pt-mat.cc (tree_matrix::rvalue): ditto. + 2007-09-05 Michael Goffioul * oct-stream.cc (octave_base_stream::do_printf): Ignore precision diff --git a/src/data.cc b/src/data.cc --- a/src/data.cc +++ b/src/data.cc @@ -759,7 +759,7 @@ if (error_state) return retval; - Array ra_idx (dv.length (), 0); + Array ra_idx (dv.length (), 0); for (int j = i; j < n_args; j++) { diff --git a/src/ov.cc b/src/ov.cc --- a/src/ov.cc +++ b/src/ov.cc @@ -1403,7 +1403,7 @@ octave_value do_cat_op (const octave_value& v1, const octave_value& v2, - const Array& ra_idx) + const Array& ra_idx) { octave_value retval; diff --git a/src/ov.h b/src/ov.h --- a/src/ov.h +++ b/src/ov.h @@ -796,7 +796,7 @@ friend OCTINTERP_API octave_value do_cat_op (const octave_value& a, const octave_value& b, - const Array& ra_idx); + const Array& ra_idx); const octave_base_value& get_rep (void) const { return *rep; } diff --git a/src/pt-mat.cc b/src/pt-mat.cc --- a/src/pt-mat.cc +++ b/src/pt-mat.cc @@ -910,7 +910,7 @@ // insert them in the result matrix. int dv_len = dv.length (); - Array ra_idx (dv_len > 1 ? dv_len : 2, 0); + Array ra_idx (dv_len > 1 ? dv_len : 2, 0); for (tm_const::iterator p = tmp.begin (); p != tmp.end (); p++) {