# HG changeset patch # User Jim Meyering # Date 952156655 0 # Node ID 056ab4fe3d27ef07d1fb80ad858c304a1c9cd2b8 # Parent 12ab2a810b6d89d69511f0a981126cc23bb1c537 Add Bruno's comment justifying use of volatile. diff --git a/lib/localcharset.c b/lib/localcharset.c --- a/lib/localcharset.c +++ b/lib/localcharset.c @@ -48,6 +48,12 @@ char *xmalloc (); char *xrealloc (); +/* The following static variable is declared 'volatile' to avoid a + possible multithread problem in the function get_charset_aliases. If we + are running in a threaded environment, and if two threads initialize + 'charset_aliases' simultaneously, both will produce the same value, + and everything will be ok if the two assignments to 'charset_aliases' + are atomic. But I don't know what will happen if the two assignments mix. */ /* Pointer to the contents of the charset.alias file, if it has already been read, else NULL. Its format is: ALIAS_1 '\0' CANONICAL_1 '\0' ... ALIAS_n '\0' CANONICAL_n '\0' '\0' */