# HG changeset patch # User Bruno Haible # Date 1285331786 -7200 # Node ID 254f2b4bf21ab44a981db1b1e2ce1865d0b5936b # Parent a4c06a233601a8eab86b3d31e881dac4f678fe23 unistr/u8-strchr: Fix a test failure on i586 glibc systems. * tests/unistr/test-strchr.h (test_strchr): Disable an invalid check. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2010-09-24 Bruno Haible + + unistr/u8-strchr: Fix a test failure on i586 glibc systems. + * tests/unistr/test-strchr.h (test_strchr): Disable an invalid check. + 2010-09-23 Bruno Haible setenv: Relax license. diff --git a/tests/unistr/test-strchr.h b/tests/unistr/test-strchr.h --- a/tests/unistr/test-strchr.h +++ b/tests/unistr/test-strchr.h @@ -121,6 +121,12 @@ } } +#if 0 + /* This check is disabled, because uN_strchr() is allowed to read past the + first occurrence of the byte being searched. In fact, u8_strchr() does + so, on i586 glibc systems: u8_strchr calls strchr, which in + glibc/sysdeps/i386/i586/strchr.S loads the second word before the + handling of the first word has been completed. */ /* Check that uN_strchr() does not read past the first occurrence of the byte being searched. */ { @@ -149,6 +155,7 @@ } } } +#endif free (input); }