# HG changeset patch # User Bruno Haible # Date 1270917680 -7200 # Node ID 563239444f8f5f2eb183b66c4a9b42f1634c2d16 # Parent 5aec4f35399f4e7fb9ee9ad8025f70edb8b744ff vasnprintf test: Reduce code duplication. diff --git a/ChangeLog b/ChangeLog --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-04-10 Bruno Haible + + vasnprintf test: Reduce code duplication. + * tests/test-vasnprintf.c (test_function): New function, extracted from + test_vasnprintf. + (test_vasnprintf, test_asnprintf): Invoke it. + 2010-04-10 Bruno Haible strnlen: Fix warning in C++ mode on MacOS X. diff --git a/tests/test-vasnprintf.c b/tests/test-vasnprintf.c --- a/tests/test-vasnprintf.c +++ b/tests/test-vasnprintf.c @@ -26,20 +26,8 @@ #include "macros.h" -static char * -my_asnprintf (char *resultbuf, size_t *lengthp, const char *format, ...) -{ - va_list args; - char *ret; - - va_start (args, format); - ret = vasnprintf (resultbuf, lengthp, format, args); - va_end (args); - return ret; -} - static void -test_vasnprintf () +test_function (char * (*my_asnprintf) (char *, size_t *, const char *, ...)) { char buf[8]; int size; @@ -73,39 +61,28 @@ } } +static char * +my_asnprintf (char *resultbuf, size_t *lengthp, const char *format, ...) +{ + va_list args; + char *ret; + + va_start (args, format); + ret = vasnprintf (resultbuf, lengthp, format, args); + va_end (args); + return ret; +} + +static void +test_vasnprintf () +{ + test_function (my_asnprintf); +} + static void test_asnprintf () { - char buf[8]; - int size; - - for (size = 0; size <= 8; size++) - { - size_t length = size; - char *result = asnprintf (NULL, &length, "%d", 12345); - ASSERT (result != NULL); - ASSERT (strcmp (result, "12345") == 0); - ASSERT (length == 5); - free (result); - } - - for (size = 0; size <= 8; size++) - { - size_t length; - char *result; - - memcpy (buf, "DEADBEEF", 8); - length = size; - result = asnprintf (buf, &length, "%d", 12345); - ASSERT (result != NULL); - ASSERT (strcmp (result, "12345") == 0); - ASSERT (length == 5); - if (size < 6) - ASSERT (result != buf); - ASSERT (memcmp (buf + size, "DEADBEEF" + size, 8 - size) == 0); - if (result != buf) - free (result); - } + test_function (asnprintf); } int