# HG changeset patch
# User Bruno Haible <bruno@clisp.org>
# Date 1260354095 -3600
# Node ID 9cd471f81705feae1bf5692e3cea3d33d248818f
# Parent  fc655d62b4b93b1a30138239223eb7a8718baea3
cloexec: Clarify code.

diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2009-12-09  Bruno Haible  <bruno@clisp.org>
+
+	* lib/cloexec.c (set_cloexec_flag): Clarify intent of dup2 call.
+
 2009-12-08  Eric Blake  <ebb9@byu.net>
 
 	fchdir: avoid memory leak on re-registration.
diff --git a/lib/cloexec.c b/lib/cloexec.c
--- a/lib/cloexec.c
+++ b/lib/cloexec.c
@@ -71,8 +71,12 @@
       errno = EBADF;
       return -1;
     }
-  return dup2 (desc, desc) == desc ? 0 : -1;
+  if (dup2 (desc, desc) < 0)
+    /* errno is EBADF here.  */
+    return -1;
 
+  /* There is nothing we can do on this kind of platform.  Punt.  */
+  return 0;
 #endif
 }