Mercurial > hg > octave-shane > gnulib-hg
changeset 17539:3ac2d2fc8782
Revert "error: make the module depend on vfprintf-posix"
This reverts commit 88e5b4d4641f294d8f824d770c9c55a1abe49768.
The GPL 'error' module is used by some of the gnulib testsuites;
and for some projects that use LGPL 'vasnprintf' in their lib/
directory, having 'error' depend on GPL 'vfprintf-posix' meant
that compilation breaks for those projects:
autoreconf: running: aclocal -I m4 --force -I m4
missing file gnulib/tests/vasnprintf.c
configure.ac:135: error: expected source file, required through
AC_LIBSOURCES, not found
m4/gnulib-comp.m4:518: gl_INIT is expanded from...
configure.ac:135: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
I suspect that the problem encountered on OS/x was a warning from
gcc complaining about inconsistent use of __attribute__((__format__
__printf__)) vs. ((__format__ __gnu_printf__)); so perhaps the
real fix is to teach error.h to copy the extra care taken by
stdio.h with regards to whether merely system or full GNU printf
specifiers are being handled. But without actually reproducing
that situation myself, the easiest action for now is to just revert
the dependency that violates the 'Comment' section of vfprintf-posix.
| author | Eric Blake <eblake@redhat.com> |
|---|---|
| date | Mon, 28 Oct 2013 14:44:04 -0600 |
| parents | 909b44293f8e |
| children | 5a97f701bcef |
| files | ChangeLog modules/error |
| diffstat | 2 files changed, 0 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -48,12 +48,6 @@ * lib/error.c (error_tail): Add the printf attribute, to placate gcc's -Werror=suggest-attribute=format option. -2013-10-12 Jim Meyering <meyering@fb.com> - - error: make the module depend on vfprintf-posix - * modules/error (Depends-on): Add vfprintf-posix, since error - calls vfprintf unconditionally, via error_tail. - 2013-09-30 Jim Meyering <meyering@fb.com> fpending, obstack, strerror-override: use pure+const function attrs