# HG changeset patch # User John W. Eaton # Date 1202849082 18000 # Node ID ada435261879e0ce135e2468ade51f3aca8e1270 # Parent 360b4f7684fdc62ab6647aec762235755f962e43 eliminate unnecessary explicit template instantiations diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog --- a/liboctave/ChangeLog +++ b/liboctave/ChangeLog @@ -1,5 +1,13 @@ 2008-02-12 John W. Eaton + * sparse-sort.cc: Don't explicitly instantiate + class octave_sort, + class octave_sort, or + class octave_sort. + + * Sparse.h (INSTANTIATE_SPARSE_SORT): Delete macro. + * Sparse-C.cc, Sparse-b.cc, Sparse-d.cc: Don't use it. + * Range.cc (Range::sort_internal): Avoid shadow warning from gcc. 2008-02-11 John W. Eaton diff --git a/liboctave/Sparse-C.cc b/liboctave/Sparse-C.cc --- a/liboctave/Sparse-C.cc +++ b/liboctave/Sparse-C.cc @@ -91,8 +91,6 @@ && (arg (a->vec) > arg (b->vec)))); } -INSTANTIATE_SPARSE_SORT (Complex); - INSTANTIATE_SPARSE_AND_ASSIGN (Complex, OCTAVE_API); INSTANTIATE_SPARSE_ASSIGN (Complex, double, OCTAVE_API); diff --git a/liboctave/Sparse-b.cc b/liboctave/Sparse-b.cc --- a/liboctave/Sparse-b.cc +++ b/liboctave/Sparse-b.cc @@ -31,8 +31,6 @@ #include "Sparse.cc" #include "oct-sort.cc" -INSTANTIATE_SPARSE_SORT (bool); - INSTANTIATE_SPARSE_AND_ASSIGN (bool, OCTAVE_API); #if 0 diff --git a/liboctave/Sparse-d.cc b/liboctave/Sparse-d.cc --- a/liboctave/Sparse-d.cc +++ b/liboctave/Sparse-d.cc @@ -60,8 +60,6 @@ return (xisnan (b->vec) || (a->vec > b->vec)); } -INSTANTIATE_SPARSE_SORT (double); - INSTANTIATE_SPARSE_AND_ASSIGN (double, OCTAVE_API); #if 0 diff --git a/liboctave/Sparse.h b/liboctave/Sparse.h --- a/liboctave/Sparse.h +++ b/liboctave/Sparse.h @@ -546,11 +546,6 @@ INSTANTIATE_SPARSE (T, API); \ INSTANTIATE_SPARSE_ASSIGN (T, T, API) -#define INSTANTIATE_SPARSE_SORT(T) \ - template class octave_sort; \ - template class vec_index; \ - template class octave_sort *>; - #endif /* diff --git a/liboctave/sparse-sort.cc b/liboctave/sparse-sort.cc --- a/liboctave/sparse-sort.cc +++ b/liboctave/sparse-sort.cc @@ -49,9 +49,6 @@ return (i->r < j->r); } -// Instantiate the sparse sorting class -template class octave_sort; - // Need to know the original order of the sorted indexes in // sparse assignments, and this class does that bool @@ -61,12 +58,6 @@ return (i->i < j->i); } -// Instantiate the sparse index sorting class -template class octave_sort; - -// Instantiate the sorting class of octave_idx_type, need in MUL macro -template class octave_sort; - /* ;;; Local Variables: *** ;;; mode: C++ ***