# HG changeset patch # User Rik # Date 1347993228 25200 # Node ID 3dcd96e1f65724476094378ec9fae79ac7a75f2c # Parent 9128fa93fb21e63717668ea4ebf348bef9aeb882 build: Comment and add FIXME notes for automake rules which never fire. * interp-core/module.mk: Comment out extra CPPFLAGS rule for display.lo. Add FIXME note on how to resolve this. * parse-tree/module.mk: Comment out AM_CXXFLAGS filter rule for lex.lo, oct-parse.lo. Add FIXME note on how to resolve this. diff --git a/libinterp/interp-core/module.mk b/libinterp/interp-core/module.mk --- a/libinterp/interp-core/module.mk +++ b/libinterp/interp-core/module.mk @@ -111,8 +111,11 @@ $(JIT_SRC) \ $(C_INTERP_CORE_SRC) -## FIXME: I don't believe this rule actually fires -display.df display.lo: CPPFLAGS += $(X11_FLAGS) +## FIXME: Automake does not support per-object rules. +## These rules could be emulated by creating a new convenience +## library and using per-library rules. Or we can just live +## without the rule since there haven't been any problems. (09/18/2012) +#display.df display.lo: CPPFLAGS += $(X11_FLAGS) ## Special rules for sources which must be built before rest of compilation. interp-core/oct-errno.cc: interp-core/oct-errno.in.cc Makefile diff --git a/libinterp/parse-tree/module.mk b/libinterp/parse-tree/module.mk --- a/libinterp/parse-tree/module.mk +++ b/libinterp/parse-tree/module.mk @@ -11,8 +11,12 @@ parse-tree/lex.ll \ parse-tree/oct-parse.yy -lex.lo lex.o oct-parse.lo oct-parse.o: \ - AM_CXXFLAGS := $(filter-out -Wold-style-cast, $(AM_CXXFLAGS)) +## FIXME: Automake does not support per-object rules. +## These rules could be emulated by creating a new convenience +## library and using per-library rules. Or we can just live +## with the extra warnings about old-sytle-casts. (09/18/2012) +#lex.lo lex.o oct-parse.lo oct-parse.o: \ +# AM_CXXFLAGS := $(filter-out -Wold-style-cast, $(AM_CXXFLAGS)) PARSE_TREE_INC = \ parse-tree/pt-all.h \