# HG changeset patch # User John W. Eaton # Date 1293009361 18000 # Node ID ed827ffa5a4316b38d50db2053e48fecb8d0be15 # Parent a7e73f903ea683d8bd722865e130818f74fce5ba optimset, optimget, __all_opts__: consistently use lower case for storing and searching options diff --git a/scripts/ChangeLog b/scripts/ChangeLog --- a/scripts/ChangeLog +++ b/scripts/ChangeLog @@ -1,3 +1,9 @@ +2010-12-22 John W. Eaton + + * optimization/optimset.m, optimization/optimget.m, + optimization/__all_opts__.m: Consistently use lower case for + storing and searching option names. + 2010-12-22 John W. Eaton * statistics/base/skewness.m: Make returned value have the same diff --git a/scripts/optimization/optimget.m b/scripts/optimization/optimget.m --- a/scripts/optimization/optimget.m +++ b/scripts/optimization/optimget.m @@ -33,7 +33,7 @@ endif opts = __all_opts__ (); - idx = lookup (toupper(opts), toupper(parname), "m"); + idx = lookup (tolower (opts), tolower (parname), "m"); if (idx) parname = opts{idx}; diff --git a/scripts/optimization/optimset.m b/scripts/optimization/optimset.m --- a/scripts/optimization/optimset.m +++ b/scripts/optimization/optimset.m @@ -47,7 +47,7 @@ ## Return defaults for named function. fcn = varargin{1}; try - retval = feval (fcn, 'defaults'); + retval = feval (fcn, "defaults"); catch error ("optimset: no defaults for function `%s'", fcn); end_try_catch @@ -59,11 +59,11 @@ fnames = fieldnames (old); ## skip validation if we're in the internal query validation = ! isempty (opts); - uopts = toupper(opts); + lopts = tolower (opts); for [val, key] = new if (validation) ## Case insensitive lookup in all options. - i = lookup (uopts, toupper(key), "i"); + i = lookup (lopts, tolower (key), "i"); ## Validate option. if (i > 0 && strcmpi (opts{i}, key)) ## Use correct case.