Mercurial > hg > octave-terminal
changeset 13217:08ba694723f5
fix warnings for unused but set variables
* base-lu.cc (base_lu<lu_type>::regular (void) const):
Don't always return true.
* base-qr.cc (base_qr<qr_type>::regular (void) const):
Don't always return true.
author | John W. Eaton <jwe@octave.org> |
---|---|
date | Sun, 25 Sep 2011 14:25:23 -0400 |
parents | 434e227b100b |
children | 01b7a60e2ff0 |
files | liboctave/base-lu.cc liboctave/base-qr.cc |
diffstat | 2 files changed, 22 insertions(+), 14 deletions(-) [+] |
line wrap: on
line diff
--- a/liboctave/base-lu.cc +++ b/liboctave/base-lu.cc @@ -173,14 +173,18 @@ bool base_lu<lu_type>::regular (void) const { + bool retval = true; + octave_idx_type k = std::min (a_fact.rows (), a_fact.columns ()); - bool retval = true; + for (octave_idx_type i = 0; i < k; i++) - if (a_fact(i, i) == lu_elt_type ()) - { - retval = false; - break; - } + { + if (a_fact(i, i) == lu_elt_type ()) + { + retval = false; + break; + } + } - return true; + return retval; }
--- a/liboctave/base-qr.cc +++ b/liboctave/base-qr.cc @@ -62,15 +62,19 @@ bool base_qr<qr_type>::regular (void) const { + bool retval = true; + octave_idx_type k = std::min (r.rows (), r.columns ()); - bool retval = true; + for (octave_idx_type i = 0; i < k; i++) - if (r(i, i) == qr_elt_type ()) - { - retval = false; - break; - } + { + if (r(i, i) == qr_elt_type ()) + { + retval = false; + break; + } + } - return true; + return retval; }