# HG changeset patch # User rubidium # Date 1247589825 0 # Node ID 8bf38ad5c253fdbac6ed747223049fd4151f2990 # Parent c2eb8db929f0846646a3eb4262b7bcc0870483f4 (svn r16827) -Codechange: make OSX specific files include stdafx.h always as the first file. Also unify OSX specific stuff into osx_stdafx.h and remove unused includes. diff --git a/src/music/qtmidi.cpp b/src/music/qtmidi.cpp --- a/src/music/qtmidi.cpp +++ b/src/music/qtmidi.cpp @@ -21,35 +21,15 @@ #ifndef NO_QUICKTIME -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#include - -/* - * OpenTTD includes. - */ -#define WindowClass OSX_WindowClass -#include -#undef WindowClass - #include "../stdafx.h" #include "qtmidi.h" +#include "../debug.h" -/* - * System includes. We need to workaround with some defines because there's - * stuff already defined in QuickTime headers. - */ -#define OTTD_Random OSX_OTTD_Random -#undef OTTD_Random -#undef WindowClass -#undef SL_ERROR -#undef bool - -#include -#include -#include - -/* we need to include debug.h after CoreServices because defining DEBUG will break CoreServices in OSX 10.2 */ -#include "../debug.h" +#define Rect OTTDRect +#define Point OTTDPoint +#include +#undef Rect +#undef Point static FMusicDriver_QtMidi iFMusicDriver_QtMidi; diff --git a/src/os/macosx/macos.mm b/src/os/macosx/macos.mm --- a/src/os/macosx/macos.mm +++ b/src/os/macosx/macos.mm @@ -1,17 +1,19 @@ /* $Id$ */ -#include +#include "../../stdafx.h" +#include "../../core/bitmath_func.hpp" +#include "../../rev.h" +#define Rect OTTDRect +#define Point OTTDPoint #include +#undef Rect +#undef Point #include #include #include #include -#include -#include "../../stdafx.h" -#include "../../core/bitmath_func.hpp" -#include "../../rev.h" #ifndef CPU_SUBTYPE_POWERPC_970 #define CPU_SUBTYPE_POWERPC_970 ((cpu_subtype_t) 100) diff --git a/src/os/macosx/osx_stdafx.h b/src/os/macosx/osx_stdafx.h --- a/src/os/macosx/osx_stdafx.h +++ b/src/os/macosx/osx_stdafx.h @@ -20,15 +20,27 @@ # error "Compiling 64 bits without _SQ64 set! (or vice versa)" #endif +#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 +#include + +/* Name conflict */ +#define Rect OTTDRect +#define Point OTTDPoint +#define WindowClass OTTDWindowClass + #include +#undef Rect +#undef Point +#undef WindowClass + /* remove the variables that CoreServices defines, but we define ourselves too */ #undef bool #undef false #undef true /* Name conflict */ -#define GetTime OTTD_GetTime +#define GetTime OTTD_GetTime #define SL_ERROR OSX_SL_ERROR diff --git a/src/sound/cocoa_s.cpp b/src/sound/cocoa_s.cpp --- a/src/sound/cocoa_s.cpp +++ b/src/sound/cocoa_s.cpp @@ -10,27 +10,18 @@ #ifdef WITH_COCOA -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#include - -#include - -/* Name conflict */ -#define Rect OTTDRect -#define Point OTTDPoint -#define WindowClass OTTDWindowClass - #include "../stdafx.h" #include "../debug.h" #include "../driver.h" #include "../mixer.h" #include "../core/endian_type.hpp" - #include "cocoa_s.h" -#undef WindowClass +#define Rect OTTDRect +#define Point OTTDPoint +#include +#undef Rect #undef Point -#undef Rect static FSoundDriver_Cocoa iFSoundDriver_Cocoa; diff --git a/src/video/cocoa/cocoa_v.mm b/src/video/cocoa/cocoa_v.mm --- a/src/video/cocoa/cocoa_v.mm +++ b/src/video/cocoa/cocoa_v.mm @@ -8,13 +8,25 @@ #ifdef WITH_COCOA -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#include +#include "../../stdafx.h" +#define Rect OTTDRect +#define Point OTTDPoint #import -#import /* gettimeofday */ +#undef Rect +#undef Point + +#include "../../openttd.h" +#include "../../debug.h" +#include "../../variables.h" +#include "../../core/geometry_type.hpp" +#include "cocoa_v.h" +#include "../../blitter/factory.hpp" +#include "../../fileio_func.h" +#include "../../gfx_func.h" +#include "../../functions.h" + #import /* for MAXPATHLEN */ -#import /** * Important notice regarding all modifications!!!!!!! @@ -43,28 +55,6 @@ #endif -/* Defined in stdbool.h */ -#ifndef __cplusplus -# ifndef __BEOS__ -# undef bool -# undef false -# undef true -# endif -#endif - - -#include "../../stdafx.h" -#include "../../openttd.h" -#include "../../debug.h" -#include "../../variables.h" -#include "../../core/geometry_type.hpp" -#include "cocoa_v.h" -#include "../../blitter/factory.hpp" -#include "../../fileio_func.h" -#include "../../gfx_func.h" -#include "../../functions.h" - - @interface OTTDMain : NSObject @end diff --git a/src/video/cocoa/event.mm b/src/video/cocoa/event.mm --- a/src/video/cocoa/event.mm +++ b/src/video/cocoa/event.mm @@ -8,34 +8,14 @@ #ifdef WITH_COCOA -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#include - -#import -#import /* gettimeofday */ -#import /* for MAXPATHLEN */ -#import +#include "../../stdafx.h" -/** - * Important notice regarding all modifications!!!!!!! - * There are certain limitations because the file is objective C++. - * gdb has limitations. - * C++ and objective C code can't be joined in all cases (classes stuff). - * Read http://developer.apple.com/releasenotes/Cocoa/Objective-C++.html for more information. - */ - +#define Rect OTTDRect +#define Point OTTDPoint +#import +#undef Rect +#undef Point -/* Defined in stdbool.h */ -#ifndef __cplusplus -# ifndef __BEOS__ -# undef bool -# undef false -# undef true -# endif -#endif - - -#include "../../stdafx.h" #include "../../openttd.h" #include "../../debug.h" #include "../../os/macosx/splash.h" @@ -50,6 +30,16 @@ #include "../../core/random_func.hpp" #include "../../texteff.hpp" +#import /* gettimeofday */ + +/** + * Important notice regarding all modifications!!!!!!! + * There are certain limitations because the file is objective C++. + * gdb has limitations. + * C++ and objective C code can't be joined in all cases (classes stuff). + * Read http://developer.apple.com/releasenotes/Cocoa/Objective-C++.html for more information. + */ + /* Right Mouse Button Emulation enum */ enum { diff --git a/src/video/cocoa/fullscreen.mm b/src/video/cocoa/fullscreen.mm --- a/src/video/cocoa/fullscreen.mm +++ b/src/video/cocoa/fullscreen.mm @@ -8,13 +8,18 @@ #ifdef WITH_COCOA -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#include +#include "../../stdafx.h" +#define Rect OTTDRect +#define Point OTTDPoint #import -#import /* gettimeofday */ -#import /* for MAXPATHLEN */ -#import +#undef Rect +#undef Point + +#include "../../debug.h" +#include "../../core/geometry_type.hpp" +#include "cocoa_v.h" +#include "../../gfx_func.h" /** * Important notice regarding all modifications!!!!!!! @@ -29,24 +34,6 @@ extern "C" void ShowMenuBar(); extern "C" void HideMenuBar(); -/* Defined in stdbool.h */ -#ifndef __cplusplus -# ifndef __BEOS__ -# undef bool -# undef false -# undef true -# endif -#endif - - -#include "../../stdafx.h" -#include "../../debug.h" -#include "../../core/geometry_type.hpp" -#include "cocoa_v.h" -#include "../../gfx_func.h" - -#undef Rect - /* Structure for rez switch gamma fades * We can hide the monitor flicker by setting the gamma tables to 0 diff --git a/src/video/cocoa/wnd_quartz.mm b/src/video/cocoa/wnd_quartz.mm --- a/src/video/cocoa/wnd_quartz.mm +++ b/src/video/cocoa/wnd_quartz.mm @@ -9,14 +9,23 @@ #ifdef WITH_COCOA #ifdef ENABLE_COCOA_QUARTZ -#include +#include "../../stdafx.h" #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4 +#define Rect OTTDRect +#define Point OTTDPoint #import -#import /* gettimeofday */ -#import /* for MAXPATHLEN */ -#import +#undef Rect +#undef Point + +#include "../../debug.h" +#include "../../rev.h" +#include "../../core/geometry_type.hpp" +#include "cocoa_v.h" +#include "../../core/math_func.hpp" +#include "../../gfx_func.h" +#include "../../functions.h" /** * Important notice regarding all modifications!!!!!!! @@ -26,29 +35,6 @@ * Read http://developer.apple.com/releasenotes/Cocoa/Objective-C++.html for more information. */ - -/* Defined in stdbool.h */ -#ifndef __cplusplus -# ifndef __BEOS__ -# undef bool -# undef false -# undef true -# endif -#endif - - -#include "../../stdafx.h" -#include "../../debug.h" -#include "../../rev.h" -#include "../../core/geometry_type.hpp" -#include "cocoa_v.h" -#include "../../core/math_func.hpp" -#include "../../gfx_func.h" -#include "../../functions.h" - -#undef Rect - - class WindowQuartzSubdriver; diff --git a/src/video/cocoa/wnd_quickdraw.mm b/src/video/cocoa/wnd_quickdraw.mm --- a/src/video/cocoa/wnd_quickdraw.mm +++ b/src/video/cocoa/wnd_quickdraw.mm @@ -9,14 +9,22 @@ #ifdef WITH_COCOA #ifdef ENABLE_COCOA_QUICKDRAW -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_3 -#define MAC_OS_X_VERSION_MAX_ALLOWED MAC_OS_X_VERSION_10_3 -#include +#define MAC_OS_X_VERSION_MAX_ALLOWED MAC_OS_X_VERSION_10_3 +#include "../../stdafx.h" +#define Rect OTTDRect +#define Point OTTDPoint #import -#import /* gettimeofday */ -#import /* for MAXPATHLEN */ -#import +#undef Rect +#undef Point + +#include "../../debug.h" +#include "../../rev.h" +#include "../../core/geometry_type.hpp" +#include "cocoa_v.h" +#include "../../core/math_func.hpp" +#include "../../gfx_func.h" +#include "../../functions.h" /** * Important notice regarding all modifications!!!!!!! @@ -27,28 +35,6 @@ */ -/* Defined in stdbool.h */ -#ifndef __cplusplus -# ifndef __BEOS__ -# undef bool -# undef false -# undef true -# endif -#endif - - -#include "../../stdafx.h" -#include "../../debug.h" -#include "../../rev.h" -#include "../../core/geometry_type.hpp" -#include "cocoa_v.h" -#include "../../core/math_func.hpp" -#include "../../gfx_func.h" -#include "../../functions.h" - -#undef Rect - - class WindowQuickdrawSubdriver;