# HG changeset patch # User tron # Date 1172156498 0 # Node ID b46247236c4f842bf671cbd26aa4bc8f05c6138e # Parent 230764f1a3168e8fbd95510686bee3977eb3857a (svn r8843) -Fix -Fix: Off-by-one error in accessing a buffer (if you start at the second byte you have to subtract one from the size) Also avoid an unnecessary buffer copy and strlcpy() abuse NOTE: 0.5 candidate diff --git a/src/newgrf.cpp b/src/newgrf.cpp --- a/src/newgrf.cpp +++ b/src/newgrf.cpp @@ -2729,11 +2729,11 @@ * * V ignored Anything following the 0C is ignored */ - static char comment[256]; if (len == 1) return; - ttd_strlcpy(comment, (char*)(buf + 1), minu(sizeof(comment), len)); - grfmsg(2, "GRFComment: %s", comment); + int text_len = len - 1; + const char *text = (const char*)(buf + 1); + grfmsg(2, "GRFComment: %.*s", text_len, text); } /* Action 0x0D (GLS_SAFETYSCAN) */