changeset 3550:33c917e8a658 draft

(svn r4416) Remove a pointless buffer copy and use strlcpy() instead of snprintf("%s")
author tron <tron@openttd.org>
date Fri, 14 Apr 2006 18:52:08 +0000
parents 003ca49d2934
children 06d036e2047e
files network_udp.c
diffstat 1 files changed, 2 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/network_udp.c
+++ b/network_udp.c
@@ -549,15 +549,12 @@
 	struct sockaddr_in out_addr;
 	Packet *p;
 	NetworkGameList *item;
-	char hostname[NETWORK_HOSTNAME_LENGTH];
 
 	// No UDP-socket yet..
 	if (_udp_client_socket == INVALID_SOCKET)
 		if (!NetworkUDPListen(&_udp_client_socket, 0, 0, true))
 			return NULL;
 
-	ttd_strlcpy(hostname, host, sizeof(hostname));
-
 	out_addr.sin_family = AF_INET;
 	out_addr.sin_port = htons(port);
 	out_addr.sin_addr.s_addr = NetworkResolveHost(host);
@@ -565,8 +562,8 @@
 	// Clear item in gamelist
 	item = NetworkGameListAddItem(inet_addr(inet_ntoa(out_addr.sin_addr)), ntohs(out_addr.sin_port));
 	memset(&item->info, 0, sizeof(item->info));
-	snprintf(item->info.server_name, sizeof(item->info.server_name), "%s", hostname);
-	snprintf(item->info.hostname, sizeof(item->info.hostname), "%s", hostname);
+	ttd_strlcpy(item->info.server_name, host, lengthof(item->info.server_name));
+	ttd_strlcpy(item->info.hostname, host, lengthof(item->info.hostname));
 	item->online = false;
 
 	// Init the packet