Mercurial > hg > openttd

changeset 4198:45ee61036cfd draft

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
(svn r5665) - Codechange: check pointers against NULL, coding style, tabulation; nothing serious.
author Darkvater <Darkvater@openttd.org>
date Sun, 30 Jul 2006 22:55:17 +0000
parents 49365e663adf
children 62d509647d94
files train_cmd.c
diffstat 1 files changed, 11 insertions(+), 14 deletions(-) [+]
line wrap: on
line diff
--- a/train_cmd.c
+++ b/train_cmd.c
@@ -958,8 +958,7 @@
 
 	// if nothing is selected as destination, try and find a matching vehicle to drag to.
 	if (d == INVALID_VEHICLE) {
-		dst = NULL;
-		if (!IsTrainEngine(src)) dst = FindGoodVehiclePos(src);
+		dst = IsTrainEngine(src) ? NULL : FindGoodVehiclePos(src);
 	} else {
 		dst = GetVehicle(d);
 	}
@@ -1009,14 +1008,13 @@
 			if (IsTrainEngine(u) && IsMultiheaded(u) && u->u.rail.other_multiheaded_part != NULL) {
 				engine = u;
 			}
-				if (engine != NULL && engine->u.rail.other_multiheaded_part == u) {
-					engine = NULL;
-				}
-				if (u == dst) {
-					if (engine != NULL) dst = engine->u.rail.other_multiheaded_part;
-					break;
-				}
-
+			if (engine != NULL && engine->u.rail.other_multiheaded_part == u) {
+				engine = NULL;
+			}
+			if (u == dst) {
+				if (engine != NULL) dst = engine->u.rail.other_multiheaded_part;
+				break;
+			}
 		}
 	}
 
@@ -1111,8 +1109,7 @@
 			}
 		} else {
 			// if moving within the same chain, dont use dst_head as it may get invalidated
-			if (src_head == dst_head)
-				dst_head = NULL;
+			if (src_head == dst_head) dst_head = NULL;
 			// unlink single wagon from linked list
 			src_head = UnlinkWagon(src, src_head);
 			GetLastEnginePart(src)->next = NULL;
@@ -1188,7 +1185,7 @@
 			src_head = NULL;	// don't do anything more to this train since the new call will do it
 		}
 
-		if (src_head) {
+		if (src_head != NULL) {
 			NormaliseTrainConsist(src_head);
 			TrainConsistChanged(src_head);
 			if (IsFrontEngine(src_head)) {
@@ -1202,7 +1199,7 @@
 			InvalidateWindow(WC_VEHICLE_DEPOT, src_head->tile);
 		};
 
-		if (dst_head) {
+		if (dst_head != NULL) {
 			NormaliseTrainConsist(dst_head);
 			TrainConsistChanged(dst_head);
 			if (IsFrontEngine(dst_head)) {