Mercurial > hg > openttd
changeset 17112:7c3f338e6d36 draft
(svn r21849) -Codechange: move merging/splitting of cargopackets into a helper function (fonsinchen)
author | rubidium <rubidium@openttd.org> |
---|---|
date | Wed, 19 Jan 2011 16:25:00 +0000 |
parents | 96fa4c5dcacf |
children | 8df0d60df814 |
files | src/cargopacket.cpp src/cargopacket.h |
diffstat | 2 files changed, 32 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/src/cargopacket.cpp +++ b/src/cargopacket.cpp @@ -86,6 +86,31 @@ } /** + * Split this packet in two and return the split off part. + * @param new_size Size of the remaining part. + * @return Split off part. + */ +FORCEINLINE CargoPacket *CargoPacket::Split(uint new_size) +{ + Money fs = this->feeder_share * new_size / static_cast<uint>(this->count); + CargoPacket *cp_new = new CargoPacket(new_size, this->days_in_transit, this->source, this->source_xy, this->loaded_at_xy, fs, this->source_type, this->source_id); + this->feeder_share -= fs; + this->count -= new_size; + return cp_new; +} + +/** + * Merge another packet into this one. + * @param cp Packet to be merged in. + */ +FORCEINLINE void CargoPacket::Merge(CargoPacket *cp) +{ + this->count += cp->count; + this->feeder_share += cp->feeder_share; + delete cp; +} + +/** * Invalidates (sets source_id to INVALID_SOURCE) all cargo packets from given source. * @param src_type Type of source. * @param src Index of source. @@ -168,10 +193,7 @@ for (List::reverse_iterator it(this->packets.rbegin()); it != this->packets.rend(); it++) { CargoPacket *icp = *it; if (Tinst::AreMergable(icp, cp) && icp->count + cp->count <= CargoPacket::MAX_COUNT) { - icp->count += cp->count; - icp->feeder_share += cp->feeder_share; - - delete cp; + icp->Merge(cp); return; } } @@ -291,16 +313,15 @@ cp->count = left; } else { /* But... the rest needs package splitting. */ - Money fs = cp->feeder_share * max_move / static_cast<uint>(cp->count); - cp->feeder_share -= fs; - cp->count -= max_move; + CargoPacket *cp_new = cp->Split(cp->count - max_move); - CargoPacket *cp_new = new CargoPacket(max_move, cp->days_in_transit, cp->source, cp->source_xy, (mta == MTA_CARGO_LOAD) ? data : cp->loaded_at_xy, fs, cp->source_type, cp->source_id); static_cast<Tinst *>(this)->RemoveFromCache(cp_new); // this reflects the changes in cp. if (mta == MTA_TRANSFER) { /* Add the feeder share before inserting in dest. */ cp_new->feeder_share += payment->PayTransfer(cp_new, max_move); + } else if (mta == MTA_CARGO_LOAD) { + cp_new->loaded_at_xy = data; } dest->Append(cp_new);
--- a/src/cargopacket.h +++ b/src/cargopacket.h @@ -62,10 +62,12 @@ /** Destroy the packet. */ ~CargoPacket() { } + CargoPacket *Split(uint new_size); + void Merge(CargoPacket *cp); /** * Gets the number of 'items' in this packet. - * @return the item count. + * @return Item count. */ FORCEINLINE uint16 Count() const {