Mercurial > hg > openttd
changeset 5618:ea1998aeffe2 draft
(svn r8077) -Cleanup: Restructure some switch() statements' default case when they're unreachable
author | Darkvater <Darkvater@openttd.org> |
---|---|
date | Fri, 12 Jan 2007 14:28:00 +0000 |
parents | ef79a2605252 |
children | 7b93afb2bd9f |
files | src/heightmap.cpp |
diffstat | 1 files changed, 20 insertions(+), 30 deletions(-) [+] |
line wrap: on
line diff
--- a/src/heightmap.cpp +++ b/src/heightmap.cpp @@ -287,18 +287,15 @@ /* Get map size and calculate scale and padding values */ switch (_patches.heightmap_rotation) { - case HM_COUNTER_CLOCKWISE: - width = MapSizeX(); - height = MapSizeY(); - break; - case HM_CLOCKWISE: - width = MapSizeY(); - height = MapSizeX(); - break; - default: - NOT_REACHED(); - /* Avoids compiler warnings */ - return; + default: NOT_REACHED(); + case HM_COUNTER_CLOCKWISE: + width = MapSizeX(); + height = MapSizeY(); + break; + case HM_CLOCKWISE: + width = MapSizeY(); + height = MapSizeX(); + break; } if ((img_width * num_div) / img_height > ((width * num_div) / height)) { @@ -315,9 +312,9 @@ for (row = 0; row < height - 1; row++) { for (col = 0; col < width - 1; col++) { switch (_patches.heightmap_rotation) { - case HM_COUNTER_CLOCKWISE: tile = TileXY(col, row); break; - case HM_CLOCKWISE: tile = TileXY(row, col); break; - default: NOT_REACHED(); return; + default: NOT_REACHED(); + case HM_COUNTER_CLOCKWISE: tile = TileXY(col, row); break; + case HM_CLOCKWISE: tile = TileXY(row, col); break; } /* Check if current tile is within the 1-pixel map edge or padding regions */ @@ -330,16 +327,13 @@ * We rotate the map 45 degrees (counter)clockwise */ img_row = (((row - row_pad) * num_div) / img_scale); switch (_patches.heightmap_rotation) { - case HM_COUNTER_CLOCKWISE: - img_col = (((width - 1 - col - col_pad) * num_div) / img_scale); - break; - case HM_CLOCKWISE: - img_col = (((col - col_pad) * num_div) / img_scale); - break; - default: - NOT_REACHED(); - /* Avoids compiler warnings */ - return; + default: NOT_REACHED(); + case HM_COUNTER_CLOCKWISE: + img_col = (((width - 1 - col - col_pad) * num_div) / img_scale); + break; + case HM_CLOCKWISE: + img_col = (((col - col_pad) * num_div) / img_scale); + break; } assert(img_row < img_height); @@ -408,17 +402,13 @@ static bool ReadHeightMap(char *filename, uint *x, uint *y, byte **map) { switch (_file_to_saveload.mode) { + default: NOT_REACHED(); #ifdef WITH_PNG case SL_PNG: return ReadHeightmapPNG(filename, x, y, map); #endif /* WITH_PNG */ case SL_BMP: return ReadHeightmapBMP(filename, x, y, map); - - default: - NOT_REACHED(); - /* Avoids compiler warnings */ - return false; } }