Mercurial > hg > octave-kai > gnulib-hg
changeset 14755:4d11fcc7fcf9
announce-gen: fail if the NEWS delta is empty
If there's nothing noteworthy in NEWS, then either you forgot
or you shouldn't be releasing.
* build-aux/announce-gen: Die if the NEWS delta is effectively empty.
author | Jim Meyering <meyering@redhat.com> |
---|---|
date | Tue, 17 May 2011 22:24:59 +0200 |
parents | 1299c18d8f6a |
children | b44f65e44220 |
files | ChangeLog build-aux/announce-gen |
diffstat | 2 files changed, 13 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-05-17 Jim Meyering <meyering@redhat.com> + + announce-gen: fail if the NEWS delta is empty + If there's nothing noteworthy in NEWS, then either you forgot + or you shouldn't be releasing. + * build-aux/announce-gen: Die if the NEWS delta is effectively empty. + 2011-05-17 Pádraig Brady <P@draigBrady.com> * top/maint.mk (_gl_tight_scope:): Automatically exclude compiler
--- a/build-aux/announce-gen +++ b/build-aux/announce-gen @@ -3,7 +3,7 @@ if 0; # Generate a release announcement message. -my $VERSION = '2011-04-29 21:01'; # UTC +my $VERSION = '2011-05-17 20:25'; # UTC # The definition above must lie within the first 8 lines in order # for the Emacs time-stamp write hook (at end) to update it. # If you change this file with Emacs, please let the write hook @@ -192,6 +192,7 @@ my $re_prefix = qr/(?:\* )?(?:Noteworthy c|Major c|C)(?i:hanges)/; + my $found_news; open NEWS, '<', $news_file or die "$ME: $news_file: cannot open for reading: $!\n"; while (defined (my $line = <NEWS>)) @@ -214,12 +215,16 @@ $line =~ /^$re_prefix.*(?:[^\d.]|$)\Q$prev_version\E(?:[^\d.]|$)/o and last; print $line; + $line =~ /\S/ + and $found_news = 1; } } close NEWS; $in_items or die "$ME: $news_file: no matching lines for `$curr_version'\n"; + $found_news + or die "$ME: $news_file: no news item found for `$curr_version'\n"; } sub print_changelog_deltas ($$)