changeset 11100:015e36a5b521

useless-if-before-free: correction It does *not* recognize "if (p != (void*)0) free(p);", since the RHS in this example may not contain ")"
author Jim Meyering <meyering@redhat.com>
date Wed, 28 Jan 2009 09:27:32 +0100
parents 635b97a3eef2
children f8d668bb8f4c
files build-aux/useless-if-before-free
diffstat 1 files changed, 3 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/build-aux/useless-if-before-free
+++ b/build-aux/useless-if-before-free
@@ -2,9 +2,9 @@
 # Detect instances of "if (p) free (p);".
 # Likewise for "if (p != NULL) free (p);".  And with braces.
 # Also detect "if (NULL != p) free (p);".
-# And with 0 or "(void *)0" in place of NULL.
+# And with 0 in place of NULL.
 
-my $VERSION = '2009-01-28 08:16'; # UTC
+my $VERSION = '2009-01-28 08:23'; # UTC
 # The definition above must lie within the first 8 lines in order
 # for the Emacs time-stamp write hook (at end) to update it.
 # If you change this file with Emacs, please let the write hook
@@ -89,9 +89,7 @@
 sub is_NULL ($)
 {
   my ($expr) = @_;
-  return ($expr eq 'NULL'
-          || $expr eq '0'
-          || $expr =~ /^\(\s*(char|void)\s*\*\s*\)\s*0$/);
+  return ($expr eq 'NULL' || $expr eq '0');
 }
 
 {