Mercurial > hg > octave-nkf

view SENDING-PATCHES @ 8951:5bce1357edd6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix conversion from PermMatrix to SparseMatrix. From 76c98628f1943d583d5813321ec0a3c684d7ac84 Mon Sep 17 00:00:00 2001 Date: Tue, 10 Mar 2009 14:12:59 -0400 The result was transposed and missing its values. Also add a test case. Signed-off-by: Jason Riedy <jason@acm.org> --- liboctave/ChangeLog | 6 ++++++ liboctave/dSparse.cc | 7 +++++-- test/ChangeLog | 4 ++++ test/test_diag_perm.m | 9 +++++++++ 4 files changed, 24 insertions(+), 2 deletions(-)
author Jason Riedy <jason@acm.org>
date Tue, 10 Mar 2009 15:44:11 -0400
parents 12ff450cbb1f
children
line wrap: on
line source

[This was originally from Richard Stallman who was writing about
 Emacs.  --jwe]

A reminder for those sending patches for Octave:

  * Always make the diffs with context.  Preferably use diff -c.  It
    is unreliable to install a diff without context, and therefore we
    probably will not take the risk of trying; instead we will
    probably ask you to send a context diff.  You might as well send
    that in your first message.

  * Always send change log entries with your patches.  Itemize the
    entries so that they list each of the functions and variables
    changed.  Look at the ChangeLog files and follow our conventions
    regarding what information to include and what style to use.

  * If the patch is to fix a bug, send a detailed bug report for the
    bug.  Make this just as detailed as if you did not have any fix
    for it.  This information is vital for convincing the maintainer
    that your fix is necessary and should be installed.  Also, if your
    fix would cause some other sort of problem, the bug report may
    enable the maintainer to find some other correct fix.

Everyone, please read the Bugs chapter in the Octave manual to see
other guidelines on how to write a bug report that makes it possible
to fix a bug.