Mercurial > hg > octave-nkf > gnulib-hg
changeset 17729:874a5cc03904
test-userspec: don't look up numeric user names
* tests/test-userspec.c: I found a system for which getpwnam("0")
returned a pointer to a non-root user's entry, and that made the
test fail.
(T): Prefix each numeric input with "+", to inhibit lookup.
| author | Jim Meyering <meyering@fb.com> |
|---|---|
| date | Fri, 18 Jul 2014 14:16:44 -0700 |
| parents | 61d8a212a342 |
| children | 71d3ac6d7927 |
| files | ChangeLog tests/test-userspec.c |
| diffstat | 2 files changed, 27 insertions(+), 19 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2014-07-18 Jim Meyering <meyering@fb.com> + + test-userspec: don't look up numeric user names + * tests/test-userspec.c: I found a system for which getpwnam("0") + returned a pointer to a non-root user's entry, and that made the + test fail. + (T): Prefix each numeric input with "+", to inhibit lookup. + 2014-07-15 Eli Zaretskii <eliz@gnu.org> localcharset, localename: MS-Windows support for non-default locales
--- a/tests/test-userspec.c +++ b/tests/test-userspec.c @@ -45,30 +45,30 @@ static struct test T[] = { - { "", -1, -1, "", "", NULL}, - { ":", -1, -1, "", "", NULL}, - { "0:0", 0, 0, "", "", NULL}, - { ":1", -1, 1, "", "", NULL}, - { "1", 1, -1, "", "", NULL}, - { ":+0", -1, 0, "", "", NULL}, - { "22:42", 22, 42, "", "", NULL}, + { "", -1, -1, "", "", NULL}, + { ":", -1, -1, "", "", NULL}, + { "+0:+0", 0, 0, "", "", NULL}, + { ":+1", -1, 1, "", "", NULL}, + { "+1", 1, -1, "", "", NULL}, + { ":+0", -1, 0, "", "", NULL}, + { "+22:+42", 22, 42, "", "", NULL}, /* (uint32_t)-1 should be invalid everywhere */ - { "4294967295:4294967295", 0, 0, NULL, NULL, "invalid user"}, + { "+4294967295:+4294967295", 0, 0, NULL, NULL, "invalid user"}, /* likewise, but with only the group being invalid */ - { "0:4294967295", 0, 0, NULL, NULL, "invalid group"}, - { ":4294967295", 0, 0, NULL, NULL, "invalid group"}, + { "+0:+4294967295", 0, 0, NULL, NULL, "invalid group"}, + { ":+4294967295", 0, 0, NULL, NULL, "invalid group"}, /* and only the user being invalid */ - { "4294967295:0", 0, 0, NULL, NULL, "invalid user"}, + { "+4294967295:+0", 0, 0, NULL, NULL, "invalid user"}, /* and using 2^32 */ - { "4294967296:4294967296", 0, 0, NULL, NULL, "invalid user"}, - { "0:4294967296", 0, 0, NULL, NULL, "invalid group"}, - { ":4294967296", 0, 0, NULL, NULL, "invalid group"}, - { "4294967296:0", 0, 0, NULL, NULL, "invalid user"}, + { "+4294967296:+4294967296", 0, 0, NULL, NULL, "invalid user"}, + { "+0:+4294967296", 0, 0, NULL, NULL, "invalid group"}, + { ":+4294967296", 0, 0, NULL, NULL, "invalid group"}, + { "+4294967296:+0", 0, 0, NULL, NULL, "invalid user"}, /* numeric user and no group is invalid */ - { "4294967295:", 0, 0, NULL, NULL, "invalid spec"}, - { "4294967296:", 0, 0, NULL, NULL, "invalid spec"}, - { "1:", 0, 0, NULL, NULL, "invalid spec"}, - { "+0:", 0, 0, NULL, NULL, "invalid spec"}, + { "+4294967295:", 0, 0, NULL, NULL, "invalid spec"}, + { "+4294967296:", 0, 0, NULL, NULL, "invalid spec"}, + { "+1:", 0, 0, NULL, NULL, "invalid spec"}, + { "+0:", 0, 0, NULL, NULL, "invalid spec"}, /* "username:" must expand to UID:GID where GID is username's login group */ /* Add an entry like the following to the table, if possible.