changeset 17919:b6d07dd90f3d

rename octave_main_thread to octave_interpreter * octave-interpreter.h, octave-interpreter.cc: Rename from octave-main-thread.h and octave-main-thread.cc. Change name of class from octave_main_thread to octave_interpreter. Change all uses. (octave_interperter::execute): Rename from execute_interpreter. * libgu/src/module.mk: Update file lists. * octave-qt-link.h, octave-qt-link.cc (octave_qt_link::octave_main_thread): Rename to command_interpreter.
author John W. Eaton <jwe@octave.org>
date Tue, 12 Nov 2013 12:36:30 -0500
parents a38cee8f0a9b
children 5c3f22dd0bbb
files libgui/src/module.mk libgui/src/octave-interpreter.cc libgui/src/octave-interpreter.h libgui/src/octave-main-thread.cc libgui/src/octave-main-thread.h libgui/src/octave-qt-link.cc libgui/src/octave-qt-link.h
diffstat 5 files changed, 18 insertions(+), 29 deletions(-) [+]
line wrap: on
line diff
--- a/libgui/src/module.mk
+++ b/libgui/src/module.mk
@@ -90,7 +90,7 @@
   src/moc-files-dock-widget.cc \
   src/moc-history-dock-widget.cc \
   src/moc-main-window.cc \
-  src/moc-octave-main-thread.cc \
+  src/moc-octave-interpreter.cc \
   src/moc-octave-qt-link.cc \
   src/moc-settings-dialog.cc \
   src/moc-news-dock-widget.cc \
@@ -127,7 +127,7 @@
   src/m-editor/octave-qscintilla.h \
   src/main-window.h \
   src/octave-gui.h \
-  src/octave-main-thread.h \
+  src/octave-interpreter.h \
   src/octave-qt-link.h \
   src/qtinfo/parser.h \
   src/qtinfo/webinfo.h \
@@ -154,7 +154,7 @@
   src/main-window.cc \
   src/octave-dock-widget.cc \
   src/octave-gui.cc \
-  src/octave-main-thread.cc \
+  src/octave-interpreter.cc \
   src/octave-qt-link.cc \
   src/qtinfo/parser.cc \
   src/qtinfo/webinfo.cc \
rename from libgui/src/octave-main-thread.cc
rename to libgui/src/octave-interpreter.cc
--- a/libgui/src/octave-main-thread.cc
+++ b/libgui/src/octave-interpreter.cc
@@ -27,16 +27,12 @@
 
 #include <string>
 
-#include "builtin-defun-decls.h"
 #include "octave.h"
-#include "ov-builtin.h"
-#include "ov-fcn-handle.h"
 
-#include "octave-main-thread.h"
-#include "octave-link.h"
+#include "octave-interpreter.h"
 
 void
-octave_main_thread::execute_interpreter (void)
+octave_interpreter::execute (void)
 {
   octave_initialize_interpreter (octave_cmdline_argc, octave_cmdline_argv,
                                  octave_embedded);
rename from libgui/src/octave-main-thread.h
rename to libgui/src/octave-interpreter.h
--- a/libgui/src/octave-main-thread.h
+++ b/libgui/src/octave-interpreter.h
@@ -21,32 +21,26 @@
 
 */
 
-#ifndef OCTAVEMAINTHREAD_H
-#define OCTAVEMAINTHREAD_H
+#ifndef octave_interpreter_h
+#define octave_interpreter_h 1
 
 #include <QObject>
 
-/**
-  * \class octave_main
-  * \brief This class represents a thread just running octave_main.
-  * \author Jacob Dawid
-  */
-class octave_main_thread : public QObject
+class octave_interpreter : public QObject
 {
   Q_OBJECT
 
 public:
 
-  // Create a new thread for running the octave interpreter.
+  // An object to manage the Octave interpreter.
 
-  octave_main_thread (void) : QObject () { }
+  octave_interpreter (void) : QObject () { }
 
 public slots:
 
-  // Start the thread and initialize and execute the octave
-  // interpreter.
+  // Initialize and execute the octave interpreter.
 
-  void execute_interpreter (void);
+  void execute (void);
 };
 
-#endif // OCTAVEMAINTHREAD_H
+#endif
--- a/libgui/src/octave-qt-link.cc
+++ b/libgui/src/octave-qt-link.cc
@@ -45,12 +45,12 @@
 
 octave_qt_link::octave_qt_link (void)
   : octave_link (), main_thread (new QThread ()),
-    octave_interpreter (new octave_main_thread ())
+    command_interpreter (new octave_interpreter ())
 {
   connect (this, SIGNAL (execute_interpreter_signal (void)),
-           octave_interpreter, SLOT (execute_interpreter (void)));
+           command_interpreter, SLOT (execute (void)));
 
-  octave_interpreter->moveToThread (main_thread);
+  command_interpreter->moveToThread (main_thread);
 
   main_thread->start ();
 }
--- a/libgui/src/octave-qt-link.h
+++ b/libgui/src/octave-qt-link.h
@@ -34,7 +34,7 @@
 #include <QThread>
 
 #include "octave-link.h"
-#include "octave-main-thread.h"
+#include "octave-interpreter.h"
 
 // Defined for purposes of sending QList<int> as part of signal.
 typedef QList<int> QIntList;
@@ -144,8 +144,7 @@
   // Thread running octave_main.
   QThread *main_thread;
 
-  // Octave interpreter (misnamed class)
-  octave_main_thread *octave_interpreter;
+  octave_interpreter *command_interpreter;
 
 signals: