Mercurial > hg > octave-nkf

changeset 15389:f918db8102d5

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
eliminate use of Q_UNUSED macro * file-editor-tab.cc (file_editor_tab::handle_event): Don't create useless temporary variable just to mark it with Q_UNUSED. (file_editor_tab::handle_margin_clicked): Don't tag state with Q_UNUSED. (file_editor_tab::file_has_changed): Eliminate argument name and corresponding Q_UNUSED. * file-editor.cc (active_tab_changed): Likeiwse. workspace-view.cc (workspace_view::item_double_clicked): Likewise.
author John W. Eaton <jwe@octave.org>
date Fri, 14 Sep 2012 11:52:44 -0400
parents 24b5348d38e7
children ad2c3902b826
files libgui/src/m-editor/file-editor-tab.cc libgui/src/m-editor/file-editor.cc libgui/src/workspace-view.cc
diffstat 3 files changed, 4 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/libgui/src/m-editor/file-editor-tab.cc
+++ b/libgui/src/m-editor/file-editor-tab.cc
@@ -139,10 +139,8 @@
           _edit_area->markerDelete (rbe->get_line (), breakpoint);
         }
 
-      if (octave_remove_all_breakpoints_event *rabe
-          = dynamic_cast<octave_remove_all_breakpoints_event*> (e))
+      if (dynamic_cast<octave_remove_all_breakpoints_event*> (e))
         {
-          Q_UNUSED (rabe);
           _edit_area->markerDeleteAll (breakpoint);
         }
     }
@@ -192,7 +190,6 @@
 file_editor_tab::handle_margin_clicked(int margin, int line,
                                        Qt::KeyboardModifiers state)
 {
-  Q_UNUSED (state);
   if (margin == 1)
     {
       unsigned int markers_mask = _edit_area->markersAtLine (line);
@@ -757,9 +754,8 @@
 }
 
 void
-file_editor_tab::file_has_changed (const QString& fileName)
+file_editor_tab::file_has_changed (const QString&)
 {
-  Q_UNUSED (fileName);
   if (QFile::exists (_file_name))
     {
       // Prevent popping up multiple message boxes when the file has
--- a/libgui/src/m-editor/file-editor.cc
+++ b/libgui/src/m-editor/file-editor.cc
@@ -353,9 +353,8 @@
 }
 
 void
-file_editor::active_tab_changed (int index)
+file_editor::active_tab_changed (int)
 {
-  Q_UNUSED (index);
   handle_editor_state_changed ();
 }
 
--- a/libgui/src/workspace-view.cc
+++ b/libgui/src/workspace-view.cc
@@ -198,9 +198,8 @@
 }
 
 void
-workspace_view::item_double_clicked (QModelIndex index)
+workspace_view::item_double_clicked (QModelIndex)
 {
-  Q_UNUSED (index);
   // TODO: Implement opening a dialog that allows the user to change a variable in the workspace.
 }