Mercurial > hg > octave-shane > gnulib-hg
changeset 14632:4843b6870f07
tests: reduce dependencies
We can assume that tests won't be run from a directory with an
absolute name longer than native getcwd limits.
* tests/test-linkat.c (main): Use lighter-weight getcwd.
* tests/test-renameat.c (main): Likewise.
* modules/linkat-tests (Depends-on): Relax dependency.
* modules/renameat-tests (Depends-on): Likewise.
* modules/fchdir-tests (Depends-on): Likewise. Also make cloexec
dependency explicit.
Signed-off-by: Eric Blake <eblake@redhat.com>
| author | Eric Blake <eblake@redhat.com> |
|---|---|
| date | Tue, 26 Apr 2011 15:23:23 -0600 |
| parents | 477dcbd7cb5d |
| children | fc14417fc753 |
| files | ChangeLog modules/fchdir-tests modules/linkat-tests modules/renameat-tests tests/test-linkat.c tests/test-renameat.c |
| diffstat | 6 files changed, 16 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2011-04-27 Eric Blake <eblake@redhat.com> + tests: reduce dependencies + * tests/test-linkat.c (main): Use lighter-weight getcwd. + * tests/test-renameat.c (main): Likewise. + * modules/linkat-tests (Depends-on): Relax dependency. + * modules/renameat-tests (Depends-on): Likewise. + * modules/fchdir-tests (Depends-on): Likewise. Also make cloexec + dependency explicit. + save-cwd: reduce default dependency * modules/save-cwd (Depends-on): Use getcwd-lgpl. * lib/save-cwd.c: Update comments.
--- a/modules/fchdir-tests +++ b/modules/fchdir-tests @@ -4,7 +4,8 @@ tests/macros.h Depends-on: -getcwd +cloexec +getcwd-lgpl configure.ac:
--- a/modules/linkat-tests +++ b/modules/linkat-tests @@ -8,9 +8,9 @@ ignore-value areadlink-with-size filenamecat +getcwd-lgpl progname same-inode -xgetcwd configure.ac:
--- a/modules/renameat-tests +++ b/modules/renameat-tests @@ -7,8 +7,8 @@ Depends-on: ignore-value filenamecat +getcwd-lgpl progname -xgetcwd configure.ac:
--- a/tests/test-linkat.c +++ b/tests/test-linkat.c @@ -34,7 +34,6 @@ #include "areadlink.h" #include "filenamecat.h" #include "same-inode.h" -#include "xgetcwd.h" #include "ignore-value.h" #include "macros.h" @@ -119,7 +118,8 @@ ASSERT (mkdir (BASE "sub1", 0700) == 0); ASSERT (mkdir (BASE "sub2", 0700) == 0); ASSERT (close (creat (BASE "00", 0600)) == 0); - cwd = xgetcwd (); + cwd = getcwd (NULL, 0); + ASSERT (cwd); dfd = open (BASE "sub1", O_RDONLY); ASSERT (0 <= dfd);
--- a/tests/test-renameat.c +++ b/tests/test-renameat.c @@ -33,7 +33,6 @@ #include <sys/stat.h> #include "filenamecat.h" -#include "xgetcwd.h" #include "ignore-value.h" #include "macros.h" @@ -79,7 +78,8 @@ dfd = creat (BASE "00", 0600); ASSERT (0 <= dfd); ASSERT (close (dfd) == 0); - cwd = xgetcwd (); + cwd = getcwd (NULL, 0); + ASSERT (cwd); dfd = open (BASE "sub1", O_RDONLY); ASSERT (0 <= dfd);