changeset 8435:6ead56c3c2b3 draft

(svn r12005) -Fix [FS#1717]: possible reading from an invalid pointer. Patch by PhilSophus.
author rubidium <rubidium@openttd.org>
date Tue, 29 Jan 2008 00:29:28 +0000
parents 1b2d9c0995f9
children 7fdca00c1151
files src/spritecache.cpp
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/spritecache.cpp
+++ b/src/spritecache.cpp
@@ -262,8 +262,8 @@
 
 void DupSprite(SpriteID old_spr, SpriteID new_spr)
 {
+	SpriteCache *scnew = AllocateSpriteCache(new_spr); // may reallocate: so put it first
 	SpriteCache *scold = GetSpriteCache(old_spr);
-	SpriteCache *scnew = AllocateSpriteCache(new_spr);
 
 	scnew->file_slot = scold->file_slot;
 	scnew->file_pos = scold->file_pos;