Mercurial > hg > octave-nkf
comparison liboctave/array/fDiagMatrix.cc @ 18564:80b8873c90ba
Fix pinv bug with 0 values introduced in cset 16b0cd465ecd.
* pinv.cc (Fpinv): Add %!tests for diagonal matrices
* CDiagMatrix.cc (pseudo_inverse), dDiagMatrix.cc (pseudo_inverse),
fCDiagMatrix.cc (pseudo_inverse), fDiagMatrix.cc (pseudo_inverse):
Don't skip assigning 0 to retval element when matrix element is 0 since
retval memory is not initialized to 0.
author | Rik <rik@octave.org> |
---|---|
date | Thu, 20 Feb 2014 09:26:45 -0800 |
parents | 1fa5bba16218 |
children | 4197fc428c7d |
comparison
equal
deleted
inserted
replaced
18562:1fa5bba16218 | 18564:80b8873c90ba |
---|---|
301 FloatDiagMatrix retval (c, r); | 301 FloatDiagMatrix retval (c, r); |
302 | 302 |
303 for (octave_idx_type i = 0; i < len; i++) | 303 for (octave_idx_type i = 0; i < len; i++) |
304 { | 304 { |
305 float val = std::abs (elem (i, i)); | 305 float val = std::abs (elem (i, i)); |
306 if (val < tol) | 306 if (val < tol || val == 0.0f) |
307 retval.elem (i, i) = 0.0f; | 307 retval.elem (i, i) = 0.0f; |
308 else if (val != 0.0f) | 308 else |
309 retval.elem (i, i) = 1.0f / elem (i, i); | 309 retval.elem (i, i) = 1.0f / elem (i, i); |
310 } | 310 } |
311 | 311 |
312 return retval; | 312 return retval; |
313 } | 313 } |