Mercurial > hg > octave-nkf

diff liboctave/array/fDiagMatrix.cc @ 18564:80b8873c90ba

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fix pinv bug with 0 values introduced in cset 16b0cd465ecd. * pinv.cc (Fpinv): Add %!tests for diagonal matrices * CDiagMatrix.cc (pseudo_inverse), dDiagMatrix.cc (pseudo_inverse), fCDiagMatrix.cc (pseudo_inverse), fDiagMatrix.cc (pseudo_inverse): Don't skip assigning 0 to retval element when matrix element is 0 since retval memory is not initialized to 0.
author Rik <rik@octave.org>
date Thu, 20 Feb 2014 09:26:45 -0800
parents 1fa5bba16218
children 4197fc428c7d
line wrap: on
line diff
--- a/liboctave/array/fDiagMatrix.cc
+++ b/liboctave/array/fDiagMatrix.cc
@@ -303,9 +303,9 @@
   for (octave_idx_type i = 0; i < len; i++)
     {
       float val = std::abs (elem (i, i));
-      if (val < tol)
+      if (val < tol || val == 0.0f)
         retval.elem (i, i) = 0.0f;
-      else if (val != 0.0f)
+      else
         retval.elem (i, i) = 1.0f / elem (i, i);
     }